You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/16 14:55:52 UTC
[GitHub] [nifi] markap14 commented on a change in pull request #3174:
NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
markap14 commented on a change in pull request #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
URL: https://github.com/apache/nifi/pull/3174#discussion_r275841876
##########
File path: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java
##########
@@ -993,6 +994,23 @@ public boolean accept(final File dir, final String filename) {
cpFiles.add(file.getAbsolutePath());
}
+ String runtimeJavaVersion = System.getProperty("java.version");
Review comment:
In reviewing this, I looked at the SystemUtils that you mention. I kinda feel that it's "6 of one, half a dozen of the other." Either way, I think, is reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services