[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #93: [IOTDB-39]add autoRepair option for NativeRestorableIOWriter

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #93: [IOTDB-39]add autoRepair option for NativeRestorableIOWriter
URL: https://github.com/apache/incubator-iotdb/pull/93#discussion_r264975515
 
 

 ##########
 File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/NativeRestorableIOWriter.java
 ##########
 @@ -53,6 +53,15 @@ long getTruncatedPosition() {
   }
 
   public NativeRestorableIOWriter(File file) throws IOException {
+    this(file, true);
 
 Review comment:
   Hi, I think the default value is true is better, because the target of using this class is for recovering broken files...
   
   For a reader class (not implemented now), the default value of `autoRepair` should be false.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services