You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2022/01/05 20:07:37 UTC

[GitHub] [nutch] prakharchaube commented on pull request #721: NUTCH-2923: Added JobId in Job Failure logs

prakharchaube commented on pull request #721:
URL: https://github.com/apache/nutch/pull/721#issuecomment-1006040395


   @lewismc I agree we should use parameterized logging however, I see the same String _message_ is further used as
   throw new RuntimeException(message);
   
   What I can do is use String.format(); to initialize the value of the message that would be neater.
   
   Another doubt in my mind was pertaining to throwing RuntimeException, is it the ideal exception choice here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org