[jira] [Commented] (YETUS-443) github pull request regular expression in the jira plugin should be more complete

["Casey Brotherton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426630#comment-15426630 ] 

Casey Brotherton commented on YETUS-443:
----------------------------------------

Have looked at the code, would be glad to look at this closer, and attach a proposed patch to the JIRA.

Would want to scan a number of JIRA texts to ensure that the regex for github pull requests is correct before suggesting a change.


> github pull request regular expression in the jira plugin should be more complete
> ---------------------------------------------------------------------------------
>
>                 Key: YETUS-443
>                 URL: https://issues.apache.org/jira/browse/YETUS-443
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.4.0
>            Reporter: Casey Brotherton
>            Priority: Minor
>
> The JIRA plugin ( jira.sh ) uses a regular expression to determine
>  if there is a github pull request that contains a patch.
> There is a duplicate regular expression in github_jira_bridge in 
> github.sh that is similar, as well as multiple regular expressions 
> in github_locate_patch that look for slightly different patterns.
> The regular expression can wrongly determine that some links are
> github pull requests, as it looks for starting with GITHUB_BASE_URL 
> and just that there are no spaces until the string "patch"  
> This regular expression should be modified, as well as consideration to whether the regexes should be combined in some way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)