You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/01/10 13:51:24 UTC
Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to
check `/files` endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279
Repository: mesos
Description
-------
Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Diffs
-----
src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
Diff: https://reviews.apache.org/r/65070/diff/1/
Testing
-------
Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
Thanks,
Qian Zhang
Re: Review Request 65070: WIP: Updated
`ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/#review195142
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64978', '65070']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65070
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65070/logs/mesos-tests-stdout.log):
```
[ OK ] ValuesTest.AddRangeCoalesce (0 ms)
[ RUN ] ValuesTest.RangesToIntervalSet
[ OK ] ValuesTest.RangesToIntervalSet (0 ms)
[ RUN ] ValuesTest.IntervalSetToRanges
[ OK ] ValuesTest.IntervalSetToRanges (0 ms)
[ RUN ] ValuesTest.RangesAddition
[ OK ] ValuesTest.RangesAddition (2 ms)
[ RUN ] ValuesTest.RangesSubtraction
[ OK ] ValuesTest.RangesSubtraction (3 ms)
[----------] 11 tests from ValuesTest (19 ms total)
[----------] 1 test from ZooKeeperURLTest
[ RUN ] ZooKeeperURLTest.URL
[ OK ] ZooKeeperURLTest.URL (1 ms)
[----------] 1 test from ZooKeeperURLTest (1 ms total)
[----------] 12 tests from GroupTest
[ RUN ] GroupTest.Group
[ OK ] GroupTest.Group (619 ms)
[ RUN ] GroupTest.GroupJoinWithDisconnect
[ OK ] GroupTest.GroupJoinWithDisconnect (41 ms)
[ RUN ] GroupTest.GroupDataWithDisconnect
[ OK ] GroupTest.GroupDataWithDisconnect (63 ms)
[ RUN ] GroupTest.GroupDataWithRemovedMembership
[ OK ] GroupTest.GroupDataWithRemovedMembership (44 ms)
[ RUN ] GroupTest.GroupCancelWithDisconnect
[ OK ] GroupTest.GroupCancelWithDisconnect (76 ms)
[ RUN ] GroupTest.GroupWatchWithSessionExpiration
D:\DCOS\mesos\mesos\src\tests\group_tests.cpp(201): error: Failed to wait 15secs for membership
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65070/logs/mesos-tests-stderr.log):
```
2018-01-10 15:20:16,141:3580(0x24e8):ZOO_INFO@log_env@753: Client environment:zookeeper.version=zookeeper C client 3.4.8
2018-01-10 15:20:16,143:3580(0x24e8):ZOO_INFO@log_env@759: Client environment:host.name=<not implemented>
2018-01-10 15:20:16,143:3580(0x24e8):ZOO_INFO@log_env@768: Client environment:os.name=<not implemented>
2018-01-10 15:20:16,144:3580(0x24e8):ZOO_INFO@log_env@769: Client environment:os.arch=<not implemented>
2018-01-10 15:20:16,144:3580(0x24e8):ZOO_INFO@log_env@770: Client environment:os.version=<not implemented>
2018-01-10 15:20:16,144:3580(0x24e8):ZOO_INFO@log_env@776: Client environment:user.name=<not implemented>
2018-01-10 15:20:16,145:3580(0x24e8):ZOO_INFO@log_env@787: Client environment:user.home=<not implemented>
2018-01-10 15:20:16,145:3580(0x24e8):ZOO_INFO@log_env@794: Client environment:user.dir=C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build
2018-01-10 15:20:16,146:3580(0x24e8):ZOO_INFO@zookeeper_init@827: Initiating client connection, host=127.0.0.1:59576 sessionTimeout=10000 watcher=00007FF7119A1400 sessionId=0 sessionPasswd=<null> context=00000201893331A0 flags=0
2018-01-10 15:20:16,147:3580(0xd8c):ZOO_INFO@check_events@1764: initiated connection to server [127.0.0.1:59576]
2018-01-10 15:20:22,814:3580(0xd8c):ZOO_ERROR@handle_socket_error_msg@1702: Socket [127.0.0.1:59576] zk retcode=-7, errno=10060(Unknown error): connection to 127.0.0.1:59576 timed out (exceeded timeout by 1ms)
2018-01-10 15:20:26,147:3580(0xd8c):ZOO_WARN@zookeeper_interest@1597: Exceeded deadline by 3334ms
W0110 15:20:26.156918 8876 group.cpp:495] Timed out waiting to connect to ZooKeeper. Forcing ZooKeeper session (sessionId=0) expiration
I0110 15:20:26.157920 8876 group.cpp:511] ZooKeeper session expired
2018-01-10 15:20:26,158:3580(0xd8c):ZOO_INFO@check_events@1764: initiated connection to server [127.0.0.1:59576]
2018-01-10 15:20:26,159:3580(0x22ac):ZOO_INFO@zookeeper_close@2579: Freeing zookeeper resources for sessionId=0
2018-01-10 15:20:26,160:3580(0xa0c):ZOO_INFO@log_env@753: Client environment:zookeeper.version=zookeeper C client 3.4.8
2018-01-10 15:20:26,161:3580(0xa0c):ZOO_INFO@log_env@759: Client environment:host.name=<not implemented>
2018-01-10 15:20:26,161:3580(0xa0c):ZOO_INFO@log_env@768: Client environment:os.name=<not implemented>
2018-01-10 15:20:26,162:3580(0xa0c):ZOO_INFO@log_env@769: Client environment:os.arch=<not implemented>
2018-01-10 15:20:26,162:3580(0xa0c):ZOO_INFO@log_env@770: Client environment:os.version=<not implemented>
2018-01-10 15:20:26,163:3580(0xa0c):ZOO_INFO@log_env@776: Client environment:user.name=<not implemented>
2018-01-10 15:20:26,163:3580(0xa0c):ZOO_INFO@log_env@787: Client environment:user.home=<not implemented>
2018-01-10 15:20:26,164:3580(0xa0c):ZOO_INFO@log_env@794: Client environment:user.dir=C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build
2018-01-10 15:20:26,165:3580(0xa0c):ZOO_INFO@zookeeper_init@827: Initiating client connection, host=127.0.0.1:59576 sessionTimeout=10000 watcher=00007FF7119A1400 sessionId=0 sessionPasswd=<null> context=0000020189333AE0 flags=0
2018-01-10 15:20:26,177:3580(0x26bc):ZOO_INFO@check_events@1764: initiated connection to server [127.0.0.1:59576]
2018-01-10 15:20:31,147:3580(0x21cc):ZOO_INFO@zookeeper_close@2579: Freeing zookeeper resources for sessionId=0
```
- Mesos Reviewbot Windows
On Jan. 10, 2018, 2:14 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65070/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 2:14 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8279
> https://issues.apache.org/jira/browse/MESOS-8279
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
>
>
> Diff: https://reviews.apache.org/r/65070/diff/1/
>
>
> Testing
> -------
>
> Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume`
to check `/files` endpoint.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/#review195465
-----------------------------------------------------------
Ship it!
Nice test!
- Vinod Kone
On Jan. 16, 2018, 3:33 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65070/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 3:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8279
> https://issues.apache.org/jira/browse/MESOS-8279
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
>
>
> Diff: https://reviews.apache.org/r/65070/diff/2/
>
>
> Testing
> -------
>
> Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume`
to check `/files` endpoint.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 11:33 p.m.)
Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Updated comments.
Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279
Repository: mesos
Description
-------
Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
Diff: https://reviews.apache.org/r/65070/diff/2/
Changes: https://reviews.apache.org/r/65070/diff/1-2/
Testing
-------
Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
Thanks,
Qian Zhang
Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume`
to check `/files` endpoint.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 10:28 p.m.)
Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279
Repository: mesos
Description
-------
Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Diffs
-----
src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
Diff: https://reviews.apache.org/r/65070/diff/1/
Testing
-------
Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
Thanks,
Qian Zhang
Re: Review Request 65070: WIP: Updated
`ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
-----------------------------------------------------------
(Updated Jan. 10, 2018, 10:14 p.m.)
Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
WIP: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279
Repository: mesos
Description
-------
Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
Diffs
-----
src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b
Diff: https://reviews.apache.org/r/65070/diff/1/
Testing
-------
Manually ran this test (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`) 100 times.
Thanks,
Qian Zhang