You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by swegner <gi...@git.apache.org> on 2016/07/28 20:39:35 UTC
[GitHub] incubator-beam pull request #753: [BEAM-436] Re-enable RunnableOnService tes...
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/753
[BEAM-436] Re-enable RunnableOnService tests which need tempRoot
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
@peihe's recent work to improve tempRoot handling means that these tests are now working properly. They can be re-enabled to validate runner display data for i/o transforms.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam io-runnableonservice
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #753
----
commit e741f32184838f598d351117e024995ff4f5d3fe
Author: Scott Wegner <sw...@google.com>
Date: 2016-07-28T20:35:55Z
Re-enable RunnableOnService tests which need tempRoot
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #753: [BEAM-436] Re-enable RunnableOnService tes...
Posted by swegner <gi...@git.apache.org>.
Github user swegner closed the pull request at:
https://github.com/apache/incubator-beam/pull/753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---