You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/05/18 09:11:47 UTC

[jira] [Created] (HBASE-3895) Fix order of parameters after HBASE-1511

Fix order of parameters after HBASE-1511
----------------------------------------

                 Key: HBASE-3895
                 URL: https://issues.apache.org/jira/browse/HBASE-3895
             Project: HBase
          Issue Type: Bug
          Components: scripts
    Affects Versions: 0.90.0
            Reporter: Lars George
            Priority: Trivial
             Fix For: 0.90.4, 0.92.0


The order of the parameters are not proper in hbase-daemon.sh. Here is a simple change that fixes it:

{noformat}
--- bin/hbase-daemon.sh (revision 1101351)
+++ bin/hbase-daemon.sh (working copy)
@@ -143,7 +143,7 @@
    echo "`ulimit -a`" >> $loglog 2>&1
    nohup nice -n $HBASE_NICENESS "$HBASE_HOME"/bin/hbase \
        --config "${HBASE_CONF_DIR}" \
-        $command $startStop "$@" > "$logout" 2>&1 < /dev/null &
+        $command "$@" $startStop > "$logout" 2>&1 < /dev/null &
    echo $! > $pid
    sleep 1; head "$logout"
    ;;
{noformat}

Also see https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028332#comment-13028332

I think this is an oversight and should have been part of the patch. Currently the local-regionservers.sh simply prints out the usage and exits, because the -D are not before the command as expected. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-3895) Fix order of parameters after HBASE-1511

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-3895.
--------------------------

      Resolution: Fixed
        Assignee: Lars George
    Hadoop Flags: [Reviewed]

I took a look at hbase-1511 and yes, I agree w/ you that the order should have been changed. Committed to branch and trunk.  Thanks for the patch Lars.

> Fix order of parameters after HBASE-1511
> ----------------------------------------
>
>                 Key: HBASE-3895
>                 URL: https://issues.apache.org/jira/browse/HBASE-3895
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.90.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Trivial
>             Fix For: 0.90.4, 0.92.0
>
>
> The order of the parameters are not proper in hbase-daemon.sh. Here is a simple change that fixes it:
> {noformat}
> --- bin/hbase-daemon.sh (revision 1101351)
> +++ bin/hbase-daemon.sh (working copy)
> @@ -143,7 +143,7 @@
>     echo "`ulimit -a`" >> $loglog 2>&1
>     nohup nice -n $HBASE_NICENESS "$HBASE_HOME"/bin/hbase \
>         --config "${HBASE_CONF_DIR}" \
> -        $command $startStop "$@" > "$logout" 2>&1 < /dev/null &
> +        $command "$@" $startStop > "$logout" 2>&1 < /dev/null &
>     echo $! > $pid
>     sleep 1; head "$logout"
>     ;;
> {noformat}
> Also see https://issues.apache.org/jira/browse/HBASE-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028332#comment-13028332
> I think this is an oversight and should have been part of the patch. Currently the local-regionservers.sh simply prints out the usage and exits, because the -D are not before the command as expected. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira