You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/11 04:01:03 UTC

[GitHub] ZhennanQin commented on issue #13581: Inplace Reshape?

ZhennanQin commented on issue #13581: Inplace Reshape?
URL: https://github.com/apache/incubator-mxnet/issues/13581#issuecomment-446064571
 
 
   Hi Jerryzcn, thanks for raising this. `Reshape` has `FInplaceOption` and `FInplaceIdentity` attrs, which means its input and output are force inlined. 
   https://github.com/apache/incubator-mxnet/blob/49e6a7e40691936e533f7cf16848b10c025e4e75/src/operator/tensor/matrix_op.cc#L177
   
   For the copy you mentioned, current implementation will do copy even when input and output are in-placed. Probably you can add a check in copy function, to skip the operation at that situation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services