You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/17 15:26:00 UTC

[jira] [Work logged] (GRIFFIN-312) Code Style Standardization

     [ https://issues.apache.org/jira/browse/GRIFFIN-312?focusedWorklogId=360946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360946 ]

ASF GitHub Bot logged work on GRIFFIN-312:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Dec/19 15:25
            Start Date: 17/Dec/19 15:25
    Worklog Time Spent: 10m 
      Work Description: chitralverma commented on pull request #560: [WIP] [GRIFFIN-312] Code Style Standardization
URL: https://github.com/apache/griffin/pull/560
 
 
   **What changes were proposed in this pull request?**
   
   This PR targets the following,
   - fix the various warnings during build and in source code,
   - perform code formatting as per a standard style,
   - fix scalastyle integration
   
   Using the [code format from spark code style can be automatically imposed on measure module. Link: https://github.com/apache/spark/blob/master/dev/.scalafmt.conf
   
   Since ScalaStyle targets scala source code only, it should be a part of the measure module only. Current misconfiguration is also suppressing the formatting errors 
   
   Scalafmt is used for code formatting.
   
   **Does this PR introduce any user-facing change?**
   No
   
   **How was this patch tested?**
   Griffin test suite.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 360946)
    Remaining Estimate: 0h
            Time Spent: 10m

> Code Style Standardization
> --------------------------
>
>                 Key: GRIFFIN-312
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-312
>             Project: Griffin
>          Issue Type: Improvement
>            Reporter: Chitral Verma
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This issue targets to,
>  * fix the various warnings during build and in source code,
>  * perform code formatting as per a standard style,
>  * fix scalastyle integration
> Using the [code format from spark code style can be automatically imposed on measure module. Link: [https://github.com/apache/spark/blob/master/dev/.scalafmt.conf]
> Since ScalaStyle targets scala source code only, it should be a part of the measure module only. Current misconfiguration is also suppressing the formatting errors 
> Scalafmt is used for code formatting. 
> Note these styles are fully configurable and can be changed at later points of time after discussion in dev community.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)