[GitHub] [airflow] yuqian90 commented on a change in pull request #17578: Improve validation of Group id

[GitBox <gi...@apache.org>]

yuqian90 commented on a change in pull request #17578:
URL: https://github.com/apache/airflow/pull/17578#discussion_r688197269



##########
File path: airflow/utils/task_group.py
##########
@@ -94,10 +95,15 @@ def __init__(
             self.used_group_ids: Set[Optional[str]] = set()
             self._parent_group = None
         else:
-            if not isinstance(group_id, str):
-                raise ValueError("group_id must be str")
-            if not group_id:
-                raise ValueError("group_id must not be empty")
+            if prefix_group_id:

Review comment:
       Is it better to always do `validate_group_key` (even if `prefix_group_id` is False)? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org