You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/04 14:43:16 UTC

[GitHub] [shardingsphere] davidChan3000 opened a new pull request, #16588: feat:modify community layout single.html

davidChan3000 opened a new pull request, #16588:
URL: https://github.com/apache/shardingsphere/pull/16588

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #16588: feat:modify community layout single.html

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #16588:
URL: https://github.com/apache/shardingsphere/pull/16588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #16588: feat:modify community layout single.html

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #16588:
URL: https://github.com/apache/shardingsphere/pull/16588#discussion_r841840116


##########
docs/community/themes/hugo-theme-learn/static/js/learn.js:
##########
@@ -417,7 +417,7 @@ window.onload = function(){
       function deal(str){
         bocs.forEach(function(item){
           if(item.getAttribute('href').split('#')[1] == str){
-            console.log(item, str)
+            // console.log(item, str)

Review Comment:
   Is it necessary to comment the log? Is it came from the 3rd party hugo theme?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu commented on pull request #16588: feat:modify community layout single.html

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #16588:
URL: https://github.com/apache/shardingsphere/pull/16588#issuecomment-1087663117

   Cloud you paste the pictures of updated website to compare the changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org