You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Jira)" <ji...@apache.org> on 2024/09/20 20:45:00 UTC

[jira] [Comment Edited] (CASSANDRA-17667) Text value containing "/*" interpreted as multiline comment in cqlsh

    [ https://issues.apache.org/jira/browse/CASSANDRA-17667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883377#comment-17883377 ] 

Brandon Williams edited comment on CASSANDRA-17667 at 9/20/24 8:44 PM:
-----------------------------------------------------------------------

Sure!  Looks good to me, let's see what CI thinks:

||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1730/workflows/1039b6fd-0e2a-478b-ab13-e864dccf3f02], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1730/workflows/80fcc967-3551-4df3-947c-dec214c4a6d7]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1731/workflows/d3dee232-159c-405c-8529-fb071e4a5a5a], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1731/workflows/321c36ae-0a3e-4e45-ab76-e6c80a20c958]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1732/workflows/148c1c87-1b12-49c8-ba49-3392b854b552], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1732/workflows/690a9f08-f122-4dd8-af78-599e292d0547]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1733/workflows/7a5e482c-f541-4ec4-86e7-3f15ee60f1b0], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1733/workflows/f5dc5f33-d0fa-4a37-b5ed-64c30bb76093]|



was (Author: brandon.williams):
Sure!  Looks good to me, let's see what CI thinks:

||Branch||CI||
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1730/workflows/1039b6fd-0e2a-478b-ab13-e864dccf3f02], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1730/workflows/80fcc967-3551-4df3-947c-dec214c4a6d7]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/1731/workflows/3d109125-68b7-4df3-9a71-f25a25f61f40], [j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1731/workflows/321c36ae-0a3e-4e45-ab76-e6c80a20c958]|
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-5.0]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1732/workflows/148c1c87-1b12-49c8-ba49-3392b854b552], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1732/workflows/690a9f08-f122-4dd8-af78-599e292d0547]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17667-trunk]|[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/1733/workflows/7a5e482c-f541-4ec4-86e7-3f15ee60f1b0], [j17|https://app.circleci.com/pipelines/github/driftx/cassandra/1733/workflows/f5dc5f33-d0fa-4a37-b5ed-64c30bb76093]|


> Text value containing "/*" interpreted as multiline comment in cqlsh
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-17667
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17667
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter
>            Reporter: ANOOP THOMAS
>            Assignee: Brad Schoening
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> I use CQLSH command line utility to load some DDLs. The version of utility I use is this:
> {noformat}
> [cqlsh 6.0.0 | Cassandra 4.0.0.47 | CQL spec 3.4.5 | Native protocol v5]{noformat}
> Command that loads DDL.cql:
> {noformat}
> cqlsh -u username -p password cassandra.example.com 65503 --ssl -f DDL.cql
> {noformat}
> I have a line in CQL script that breaks the syntax.
> {noformat}
> INSERT into tablename (key,columnname1,columnname2) VALUES ('keyName','value1','/value2/*/value3');{noformat}
> {{/*}} here is interpreted as start of multi-line comment. It used to work on older versions of cqlsh. The error I see looks like this:
> {noformat}
> SyntaxException: line 4:2 mismatched input 'Update' expecting ')' (...,'value1','/value2INSERT into tablename(INSERT into tablename (key,columnname1,columnname2)) VALUES ('[Update]-...) SyntaxException: line 1:0 no viable alternative at input '(' ([(]...)
> {noformat}
> Same behavior while running in interactive mode too. {{/*}} inside a CQL statement should not be interpreted as start of multi-line comment.
> With schema:
> {code:java}
> CREATE TABLE tablename ( key text primary key, columnname1 text, columnname2 text);{code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org