You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2024/07/24 13:02:51 UTC

[PR] MINOR: Update collaborators list [kafka]

jlprat opened a new pull request, #16679:
URL: https://github.com/apache/kafka/pull/16679

   I did the following:
   
   > git shortlog --email --numbered --summary --since=2023-07-24 > /tmp/contributors.txt
   
   Then I excluded all committers from the list.
   
   Cut the list to the top 10 and for each member I found their GitHub user name. List is in order of commits.
   
   Note I used the `--email` flag as stated in https://issues.apache.org/jira/browse/KAFKA-14995
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248161020

   > I can give it a try and hope we don't have two people with the same name 
   I tried the original command you shared and definitely my email is shown twice once 
   ```
       27 Omnia Ibrahim <o....@gmail.com>
       4	 Omnia G.H Ibrahim <o....@gmail.com>
   ```
   
   This make my total 31 which should be right after `34	Nikolay <ni...@apache.org>` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248222779

   > How about using Github contributors page?
   
   1. [FrankYang0529](https://github.com/FrankYang0529)
   3. [kamalcph](https://github.com/kamalcph)
   4. [apoorvmittal10](https://github.com/apoorvmittal10)
   5. [lianetm](https://github.com/lianetm)
   6. [brandboat](https://github.com/brandboat)
   7. [kirktrue](https://github.com/kirktrue)
   8. [nizhikov](https://github.com/nizhikov)
   10. [OmniaGM](https://github.com/OmniaGM)
   11. [dongnuo123](https://github.com/dongnuo123)
   12. [frankvicky](https://github.com/frankvicky)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248154085

   maybe we should ping those active contributors to take a look at this PR. Otherwise, they could never know that permission.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248361782

   I updated [KAFKA-14995](https://issues.apache.org/jira/browse/KAFKA-14995) to reflect this way to obtain the contributors that seems more fair than the one with emails or names.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248136063

   Nice PR one problem with the used command is that any one that has same email but different name attached to the commit don't count as one person. 
   
   I tried this 
   ```
   git shortlog --email --numbered --summary --since=2023-07-24 | awk '
   {
     # Extract email (the part between < and >)
     match($0, /<[^>]*>/);
     email = substr($0, RSTART+1, RLENGTH-2);
   
     # Add to the associative array
     commits[email] += $1;
   }
   
   END {
     # Print the result
     for (email in commits) {
       print commits[email], email;
     }
   }
   ' | sort -nr
   ```
   
   and got slightly different order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat merged PR #16679:
URL: https://github.com/apache/kafka/pull/16679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248230183

   > How about using Github contributors page?
   > 
   > https://github.com/apache/kafka/graphs/contributors?from=2023-07-24&to=2024-07-24&type=c
   
   I think this is the most accurate one at least it count for these GitHub email and name issue. And for cases where someone is mixing personal and work emails then sadly this case can't be counted as one person that easily. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248212845

   > > Same with others
   > 
   > another case:
   > 
   > ```
   > 20 kitingiao@gmail.com
   > 12 51072200+frankvicky@users.noreply.github.com
   > ```
   > 
   > Those active contributors have many alias :)
   
   yup this is the tricky one I mentioned above same person different emails :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248185871

   I think the tricky part would be same person two emails :D but I can't find such one in the original `git shortlog --email --numbered --summary --since=2023-07-24` command yet. Hopefully we don't have this case 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248144646

   I can give it a try and hope we don't have two people with the same name 😃


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248200047

   > Same with others
   
   another case:
   ```
   20 kitingiao@gmail.com
   12 51072200+frankvicky@users.noreply.github.com
   ```
   Those active contributors have many alias :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248397983

   I'll merge this PR, as the pipelines don't check this file and we don't need to waste CPU cycles on this.
   
   
   Mentioning the newly added collaborators here as an FYI - @FrankYang0529 @apoorvmittal10 @lianetm @brandboat @kirktrue @nizhikov @OmniaGM @dongnuo123 @frankvicky . Welcome all! Let us know if you have any questions!
   
   You can check out the Collaborators section on https://kafka.apache.org/contributing, or this [dev mailing list thread](https://lists.apache.org/thread/93lb6jhkjkmb9op9629xt6c6olwym28c) for more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248209765

   ```
   20 kitingiao@gmail.com
   12 51072200+frankvicky@users.noreply.github.com 
   ```
   Yes this is me.
   This happened because I didn't know that GitHub has private email protection before... 😥


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248207933

   How about using Github contributors page? 
   
   https://github.com/apache/kafka/graphs/contributors?from=2023-07-24&to=2024-07-24&type=c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Update collaborators list [kafka]

Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16679:
URL: https://github.com/apache/kafka/pull/16679#issuecomment-2248353387

   > maybe we should ping those active contributors to take a look at this PR. Otherwise, they could never know that permission.
   
   Yes @chia7712 , I was planning on doing this once we had the changes merged to make sure the pinged people were the ones that made it to the list for sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org