You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/10/23 18:38:09 UTC

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3164
    https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
-------

Quota: Moved QuotaInfo protobuf into a separate package.


Diffs
-----

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
-------

make check


Thanks,

Alexander Rukletsov

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

Posted by Qian Zhang <zh...@cn.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/#review103944
-----------------------------------------------------------

Ship it!


Ship It!

- Qian Zhang


On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39317/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Moved QuotaInfo protobuf into a separate package.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
> 
> Diff: https://reviews.apache.org/r/39317/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

Posted by Joris Van Remoortere <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/#review105165
-----------------------------------------------------------

Ship it!



include/mesos/master/quota.proto (lines 27 - 32)
<https://reviews.apache.org/r/39317/#comment163585>

    It's nice that within this review you made an explicit decision not to copy this to V1. You also have some great argument for that. Can you please capture these as a comment in the code here so that users and future developers will see the path forward?


- Joris Van Remoortere


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39317/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Moved QuotaInfo protobuf into a separate package.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
> 
> Diff: https://reviews.apache.org/r/39317/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>