You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/20 15:18:10 UTC
[GitHub] [airflow-site] anselboero opened a new pull request, #641: Doc menu items are not collapsible #24963
anselboero opened a new pull request, #641:
URL: https://github.com/apache/airflow-site/pull/641
Closes Airflow [#24963](https://github.com/apache/airflow/issues/24963[](url)) Issue.
Clicking on the the active menu's arrow will show/hide the submenus.
I noticed that the **globaltoc.html** page is repeated 2 times in the web pages.
The first time the HTML code is inserted inside the "**content-drawer-wrapper**" div, used to render the sidebar inside the "Content" hamburger button, which is shown only when the horizontal screen reaches a small width.
The HTML code of the **globaltoc.html** file is then used to render the sidebar which is displayed under normal conditions.
This is why I included the Javascript code in a new file, I wanted to avoid it being run twice.
I'm not a front-end expert, but I don't think repeating the same Html and Css code twice to make the page responsive is considered a good practice. If you agree I could study the Sphinx documentation better and try to refactor the **sphinx_airflow_theme**, trying to remove the redundant parts.
Thank you very much for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1190544350
Unfortunately lint is failing - you need to fix it (pre-commit will do it automatically for you so I recommend to install it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk merged pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #641:
URL: https://github.com/apache/airflow-site/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1192490145
You can exclude your file from being linted in the appropriate entrry of .pre-commit.yam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1192543826
Woohoo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1190517617
WHOA !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] anselboero commented on pull request #641: Doc menu items are not collapsible #24963
Posted by GitBox <gi...@apache.org>.
anselboero commented on PR #641:
URL: https://github.com/apache/airflow-site/pull/641#issuecomment-1192406011
Thanks a lot Potiuk for your feedback.
Unfortunately there are two points that should be considered before the pull request can be approved (They have global relevance and are not specific to this PR, if necessary I can open a new discussion).
- Error: **ESLint couldn't find a configuration file.**
I got this error as the new Js file is located in the **./sphinx_airflow_theme/sphinx_airflow_theme/static/js** folder but the configuration file used by Lint is located in the **./landing-pages** folder, which isn't an ancestor folder for the new Js file: for this reason Lint cannot check the new Js file.
I tried to add the configuration file in an ancestor folder but this approach isn't sufficient as it's also necessary to add in the configuration file's folder the **node_modules** directory, that is at the moment created and saved by yarn in the landing-pages folder (Otherwise Lint cannot find some dependencies such as babel-eslint)
Therefore **at the moment I think it is not possible to run Lint on Js files saved in folders other than ./landing-pages/*.**
- **Add Jquery to the Lint-Js configuration file**
Would it be possible to include the Jquery library among the environments accepted by Lint or did we decide not to use Jquery to create the site? (Although sphinx uses it)
Thank you very much and sorry if the comment may seem too long or unclear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org