You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Chris Colman (Created) (JIRA)" <ji...@apache.org> on 2012/01/10 10:46:38 UTC
[jira] [Created] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Non standard ("wicket") namespace causes incorrect relative URL in certain cases
--------------------------------------------------------------------------------
Key: WICKET-4330
URL: https://issues.apache.org/jira/browse/WICKET-4330
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.3
Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
Reporter: Chris Colman
The problem is related to non standard (i.e. "wicket") namespaces.
In my quickstart if I change the namespace in all markup from "wicket"
to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
i.e.
Browser is at this page:
http://127.0.0.1/content/other/o/1234/aspect/fred
<p>
Here's a relative link to another page in the same 'path'
<div>
<a foobar:id="janeLink" href="../../../../../jane"
style="outline: 0;">
jane
</a>
</div>
</p>
<p>
A link to the current page
<a foobar:id="fredLink" href="fred">fred</a> </p>
The above BPL href of ../../../../../jane is wrong.
With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
This same code worked with the non standard namespace under 1.4.x
Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183309#comment-13183309 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
Otherwise the problem seems to be the check for "wicket:id" in org.apache.wicket.markup.parser.filter.RelativePathPrefixHandler#onComponentTag().
It doesn't honor changed namespaces for MarkupParser (I still don't see you doing this anyway).
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183963#comment-13183963 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
AFAIK you need to configure the namespace with org.apache.wicket.markup.AbstractMarkupParser#setWicketNamespace().
I haven't had time to debug how now <foobar:panel> actually works.
But even with #setWicketNamespace("foobar") the problems in my previous comment will break your application.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183322#comment-13183322 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
wicket:message wont work as well with changed namespace:
/** TODO Post 1.2: General: Namespace should not be a constant */
private final static String WICKET_MESSAGE_ATTRIBUTE_NAME = "wicket:message";
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183440#comment-13183440 ]
Chris Colman commented on WICKET-4330:
--------------------------------------
> You don't specify anywhere that 'foobar' is a replacement for 'wicket' namespace. Or at least I don't see it.
It's specified in the html tag of each markup file. That was all that was required to change the namespace in 1.4.x. In fact in 1.4.x we even had some markup specified with "wicket" namespace and others specified with "foobar" namespace and it worked perfectly - even markup inheritance worked with markups in the hierarchy having *different* namespaces.
Are you saying that in 1.5.x we need to specify a namespace change in the java code somewhere?
> General: Namespace should not be a constant
I had a hunch that some hard coded "wicket" namespace references in 1.5.x might be related or the cause of the issue.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4330:
---------------------------------------
Assignee: Martin Grigorov
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184009#comment-13184009 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
All is fine.
It appears that org.apache.wicket.markup.parser.filter.WicketNamespaceHandler is responsible to extract the namespace from <html xmlns:...> and set it for the MarkupResourceStream.
I'll fix the issues in the comments above.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183967#comment-13183967 ]
Chris Colman commented on WICKET-4330:
--------------------------------------
That must be a change since 1.4.x where we've been using different namespaces that were specified purely at the markup level with no Java code to specify them.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Colman updated WICKET-4330:
---------------------------------
Attachment: nonStdNamespaceBug.zip
Quickstart - uses port 80, not 8080!
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183304#comment-13183304 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
How this application even works ?
You don't specify anywhere that 'foobar' is a replacement for 'wicket' namespace. Or at least I don't see it.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481022#comment-13481022 ]
Chris Colman commented on WICKET-4330:
--------------------------------------
This bug has now regressed in 6.1.1 (and continues to regress in latest 6.2 snapshot). The app will display an error on the homepage.
The attached snapshot reproduces the problem.
If the namespace declaration in StandardPage.html <html> is removed and "foobar" replaced with "wicket" the homepage displays without error.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Fix For: 1.5.5, 6.0.0-beta1
>
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4330.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.5
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Fix For: 1.5.5, 6.0.0
>
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183328#comment-13183328 ]
Martin Grigorov commented on WICKET-4330:
-----------------------------------------
org.apache.wicket.markup.html.form.AutoLabelTextResolver.TextLabel#findLabelContent has:
String text = formComponent.getDefaultLabel("wicket:unknown");
if (!"wicket:unknown".equals(text) && !Strings.isEmpty(text))
I'm not sure wicket:unknown is even documented anywhere... :-/
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Colman updated WICKET-4330:
---------------------------------
Comment: was deleted
(was: This bug has now regressed in 6.1.1 (and continues to regress in latest 6.2 snapshot). The app will display an error on the homepage.
The attached snapshot reproduces the problem.
If the namespace declaration in StandardPage.html <html> is removed and "foobar" replaced with "wicket" the homepage displays without error.)
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Fix For: 1.5.5, 6.0.0-beta1
>
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184374#comment-13184374 ]
Chris Colman commented on WICKET-4330:
--------------------------------------
Thanks Martin! That works really well now.
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Assignee: Martin Grigorov
> Labels: wicket
> Fix For: 1.5.5, 6.0.0
>
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4330) Non standard ("wicket") namespace
causes incorrect relative URL in certain cases
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183169#comment-13183169 ]
Chris Colman commented on WICKET-4330:
--------------------------------------
The cause of the issue seems to be that the BPL tag is incorrectly having the RelativePathPrefixHandler invoked on it. With the non standard namespace Wicket confuses this BPL for a non wicket tag and so applies that filter which causes the damage to the href when it attempts to make an already relative link relative ... again ;)
> Non standard ("wicket") namespace causes incorrect relative URL in certain cases
> --------------------------------------------------------------------------------
>
> Key: WICKET-4330
> URL: https://issues.apache.org/jira/browse/WICKET-4330
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Environment: Win XP, 4GB RAM, Tomcat 6, Java 6
> Reporter: Chris Colman
> Labels: wicket
> Attachments: nonStdNamespaceBug.zip
>
>
> The problem is related to non standard (i.e. "wicket") namespaces.
> In my quickstart if I change the namespace in all markup from "wicket"
> to "foobar" then the BPL which has only the last segment differing from the current page ends up producing an incorrect link to another page in the same path.
> i.e.
> Browser is at this page:
> http://127.0.0.1/content/other/o/1234/aspect/fred
> <p>
> Here's a relative link to another page in the same 'path'
> <div>
> <a foobar:id="janeLink" href="../../../../../jane"
> style="outline: 0;">
> jane
> </a>
> </div>
> </p>
> <p>
> A link to the current page
> <a foobar:id="fredLink" href="fred">fred</a> </p>
> The above BPL href of ../../../../../jane is wrong.
> With 'wicket' set as the namespace the 'jane' BPL outputs 'jane' which is correct.
> This same code worked with the non standard namespace under 1.4.x
> Attached quickstart demonstrates the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira