You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2012/02/23 20:04:51 UTC

[jira] [Commented] (HADOOP-8085) Add RPC metrics to ProtobufRpcEngine

    [ https://issues.apache.org/jira/browse/HADOOP-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214941#comment-13214941 ] 

Hadoop QA commented on HADOOP-8085:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12515772/HADOOP-8085.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.ipc.TestMultipleProtocolServer

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/620//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/620//console

This message is automatically generated.
                
> Add RPC metrics to ProtobufRpcEngine
> ------------------------------------
>
>                 Key: HADOOP-8085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8085
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc, metrics
>    Affects Versions: 0.24.0, 0.23.2
>            Reporter: Suresh Srinivas
>            Assignee: Hari Mankude
>         Attachments: HADOOP-8085.patch
>
>
> ProtobufRpcEngine is missing the RPC metrics compared to WritableRpcEngine. It is important information for monitoring the cluster and understanding the server performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira