You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2013/07/12 13:10:56 UTC
Re: git commit: WICKET-5071 use url as clientUrl
On Fri, Jul 12, 2013 at 2:07 PM, <sv...@apache.org> wrote:
> Updated Branches:
> refs/heads/wicket-6.x 10b4892f3 -> cc0668452
>
>
> WICKET-5071 use url as clientUrl
>
WICKET-5272
But I'm not sure what is the 'svn propchange' Git command
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cc066845
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cc066845
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cc066845
>
> Branch: refs/heads/wicket-6.x
> Commit: cc06684525808d922e3e0c76b1df60805cbab5da
> Parents: 10b4892
> Author: svenmeier <sv...@meiers.net>
> Authored: Fri Jul 12 12:58:24 2013 +0200
> Committer: svenmeier <sv...@meiers.net>
> Committed: Fri Jul 12 12:58:24 2013 +0200
>
> ----------------------------------------------------------------------
> .../org/apache/wicket/request/mapper/CompoundRequestMapper.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/cc066845/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
> index ae13ac2..13785e3 100644
> ---
> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
> +++
> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
> @@ -288,7 +288,7 @@ public class CompoundRequestMapper implements
> ICompoundRequestMapper
> @Override
> public Url getClientUrl()
> {
> - return null;
> + return url;
> }
>
> @Override
>
>
Re: git commit: WICKET-5071 use url as clientUrl
Posted by Michael Mosmann <mi...@mosmann.de>.
in human history the past is allways changing...
> human history is not cryptographically hashed :(
>
> On Fri, Jul 12, 2013 at 6:36 AM, Martin Grigorov <mg...@apache.org> wrote:
>> On Fri, Jul 12, 2013 at 4:33 PM, Jeremy Thomerson <jeremy@wickettraining.com
>>> wrote:
>>> On Fri, Jul 12, 2013 at 7:34 AM, Sven Meier <sv...@meiers.net> wrote:
>>>
>>>> Sorry, that was the wrong issue number in the clipboard.
>>>>
>>>> Changing the last commit message after push? Linus says "don't to it":
>>>>
>>>> http://stackoverflow.com/**questions/457379/how-do-i-**
>>>> edit-an-incorrect-commit-**message-in-git-ive-pushed/**457396#457396<
>>> http://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commit-message-in-git-ive-pushed/457396#457396
>>>
>>> Besides, history rewriting is disallowed at ASF (for good reason).
>>>
>> For SVN it is not disallowed.
>> But I guess you mean just Git history, not human history :-)
Re: git commit: WICKET-5071 use url as clientUrl
Posted by Igor Vaynberg <ig...@gmail.com>.
human history is not cryptographically hashed :(
On Fri, Jul 12, 2013 at 6:36 AM, Martin Grigorov <mg...@apache.org> wrote:
> On Fri, Jul 12, 2013 at 4:33 PM, Jeremy Thomerson <jeremy@wickettraining.com
>> wrote:
>
>> On Fri, Jul 12, 2013 at 7:34 AM, Sven Meier <sv...@meiers.net> wrote:
>>
>> > Sorry, that was the wrong issue number in the clipboard.
>> >
>> > Changing the last commit message after push? Linus says "don't to it":
>> >
>> > http://stackoverflow.com/**questions/457379/how-do-i-**
>> > edit-an-incorrect-commit-**message-in-git-ive-pushed/**457396#457396<
>> http://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commit-message-in-git-ive-pushed/457396#457396
>> >
>>
>>
>> Besides, history rewriting is disallowed at ASF (for good reason).
>>
>
> For SVN it is not disallowed.
> But I guess you mean just Git history, not human history :-)
Re: git commit: WICKET-5071 use url as clientUrl
Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Jul 12, 2013 at 4:33 PM, Jeremy Thomerson <jeremy@wickettraining.com
> wrote:
> On Fri, Jul 12, 2013 at 7:34 AM, Sven Meier <sv...@meiers.net> wrote:
>
> > Sorry, that was the wrong issue number in the clipboard.
> >
> > Changing the last commit message after push? Linus says "don't to it":
> >
> > http://stackoverflow.com/**questions/457379/how-do-i-**
> > edit-an-incorrect-commit-**message-in-git-ive-pushed/**457396#457396<
> http://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commit-message-in-git-ive-pushed/457396#457396
> >
>
>
> Besides, history rewriting is disallowed at ASF (for good reason).
>
For SVN it is not disallowed.
But I guess you mean just Git history, not human history :-)
Re: git commit: WICKET-5071 use url as clientUrl
Posted by Jeremy Thomerson <je...@wickettraining.com>.
On Fri, Jul 12, 2013 at 7:34 AM, Sven Meier <sv...@meiers.net> wrote:
> Sorry, that was the wrong issue number in the clipboard.
>
> Changing the last commit message after push? Linus says "don't to it":
>
> http://stackoverflow.com/**questions/457379/how-do-i-**
> edit-an-incorrect-commit-**message-in-git-ive-pushed/**457396#457396<http://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commit-message-in-git-ive-pushed/457396#457396>
Besides, history rewriting is disallowed at ASF (for good reason).
Re: git commit: WICKET-5071 use url as clientUrl
Posted by Sven Meier <sv...@meiers.net>.
Sorry, that was the wrong issue number in the clipboard.
Changing the last commit message after push? Linus says "don't to it":
http://stackoverflow.com/questions/457379/how-do-i-edit-an-incorrect-commit-message-in-git-ive-pushed/457396#457396
Sven
On 07/12/2013 01:10 PM, Martin Grigorov wrote:
> On Fri, Jul 12, 2013 at 2:07 PM, <sv...@apache.org> wrote:
>
>> Updated Branches:
>> refs/heads/wicket-6.x 10b4892f3 -> cc0668452
>>
>>
>> WICKET-5071 use url as clientUrl
>>
> WICKET-5272
> But I'm not sure what is the 'svn propchange' Git command
>
>
>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/cc066845
>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/cc066845
>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/cc066845
>>
>> Branch: refs/heads/wicket-6.x
>> Commit: cc06684525808d922e3e0c76b1df60805cbab5da
>> Parents: 10b4892
>> Author: svenmeier <sv...@meiers.net>
>> Authored: Fri Jul 12 12:58:24 2013 +0200
>> Committer: svenmeier <sv...@meiers.net>
>> Committed: Fri Jul 12 12:58:24 2013 +0200
>>
>> ----------------------------------------------------------------------
>> .../org/apache/wicket/request/mapper/CompoundRequestMapper.java | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/cc066845/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
>> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
>> index ae13ac2..13785e3 100644
>> ---
>> a/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
>> +++
>> b/wicket-request/src/main/java/org/apache/wicket/request/mapper/CompoundRequestMapper.java
>> @@ -288,7 +288,7 @@ public class CompoundRequestMapper implements
>> ICompoundRequestMapper
>> @Override
>> public Url getClientUrl()
>> {
>> - return null;
>> + return url;
>> }
>>
>> @Override
>>
>>