You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2026/09/30 01:20:17 UTC
[PR] [10.5] Ensure BitSetConjunctionDISI exhausts all sub-iterators [lucene]
michaeljmarshall opened a new pull request, #16747:
URL: https://github.com/apache/lucene/pull/16747
### Summary
- Backport the exhaustion-state fix from #16146 to `branch_10_5`. Brief comments here https://github.com/apache/lucene/pull/16146#discussion_r4138521657
- Keep retained `BitSetIterator`s synchronized with the lead iterator at `NO_MORE_DOCS`.
- Strengthen the existing regression test to verify every constituent iterator's state.
Test:
```
./gradlew :lucene:core:test --tests org.apache.lucene.search.TestConjunctionDISI
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [10.5] Ensure BitSetConjunctionDISI exhausts all sub-iterators [lucene]
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #16747:
URL: https://github.com/apache/lucene/pull/16747#issuecomment-5902254821
Looks like CI failed for a procedural reason.
```
Prepare all required actions
Getting action download info
Error: The action gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e is not allowed in apache/lucene because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: 1Password/load-secrets-action/configure@3a12b0ab99d9cd590a3e9b5a90ea017210ed9556, 1Password/load-secrets-action/configure@70062d7a876d3eb6334754fa26efd2fbd90c32f2, 1Password/load-secrets-action/configure@e544b780808654ba8ceba5fb2fe2897103d92ff4, 1Password/load-secrets-action/configure@eb2efd0703da22a93c467f2d1ffbb6826c11e19c, 1Password/load-secrets-action@3a12b0ab99d9cd590a3e9b5a90ea017210ed9556, 1Password/load-secrets-action@70062d7a876d3eb6334754fa26efd2fbd90c32f2, 1Password/load-secrets-action@e544b780808654ba8ceba5fb2fe2897103d92ff4, 1Password/load-secrets-action@eb2efd0703da22a93c467f2d1ffbb6826c11e19c, AdoptOpenJDK/install-jdk@*, BobAnkh/auto-generate-changelog@*, CodSpeedHQ/action@373d6868929f444bc08d901fd0eb0ad52a8875ea, DavidAnson/markd
ownlint-c...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [10.5] Ensure BitSetConjunctionDISI exhausts all sub-iterators [lucene]
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #16747:
URL: https://github.com/apache/lucene/pull/16747#issuecomment-5914627368
The main argument against back porting this bug fix is that calling `advance()` or `nextDoc()` on an iterator after it already returned NO_MORE_DOCS is documented as being undefined. My main thinking was that the fact that a passed in iterator is not advanced to `NO_MORE_DOCS` is itself a bug. I had an agent review the lucene code base and it couldn't find any incorrect usages (doesn't mean there aren't any).
As such, I can see an argument for merging or closing without merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] [10.5] Ensure BitSetConjunctionDISI exhausts all sub-iterators [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16747:
URL: https://github.com/apache/lucene/pull/16747#issuecomment-6181612117
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org