[GitHub] [helix] i3wangyi commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #637: Add new WAGED rebalancer config item "GLOBAL_REBALANCE_ASYNC_MODE".
URL: https://github.com/apache/helix/pull/637#discussion_r353446661
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
 ##########
 @@ -822,6 +838,19 @@ public void setGlobalRebalancePreference(Map<GlobalRebalancePreferenceKey, Integ
     return DEFAULT_GLOBAL_REBALANCE_PREFERENCE;
   }
 
+  /**
+   * Set the asynchronous global rebalance mode.
 
 Review comment:
   nit: the method will be used mostly by client library, could you make the java doc more concrete? How often the async rebalance will be triggered, estimated impact, default value and so on?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org