You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gong (via GitHub)" <gi...@apache.org> on 2023/11/13 07:24:22 UTC
[PR] [INLONG-9273][Sort] IcebergSingleFileCommiter will throw exception for error code [inlong]
gong opened a new pull request, #9274:
URL: https://github.com/apache/inlong/pull/9274
### Prepare a Pull Request
- [INLONG-9273][Sort] IcebergSingleFileCommiter will throw exception for error code
- Fixes #9273
### Motivation
* Fix IcebergSingleFileCommiter throw exception
### Modifications
* remove error code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9273][Sort] IcebergSingleFileCommiter will throw exception for error code [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #9274:
URL: https://github.com/apache/inlong/pull/9274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9273][Sort] IcebergSingleFileCommiter will throw exception for error code [inlong]
Posted by "thexiay (via GitHub)" <gi...@apache.org>.
thexiay commented on code in PR #9274:
URL: https://github.com/apache/inlong/pull/9274#discussion_r1392051892
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/IcebergSingleFileCommiter.java:
##########
@@ -316,9 +316,6 @@ private void commitUpToCheckpoint(NavigableMap<Long, byte[]> deltaManifestsMap,
}
continuousEmptyCheckpoints = 0;
}
- // remove already committed snapshot manifest info
-
- pendingMap.keySet().forEach(deltaManifestsMap::remove);
Review Comment:
this may be useless, because deltaManifestsMap is type `NavigableMap`， it's real type is `TreeMap`. The pendingMap is a view of treemap.
when call it's `clear()` it infact use iterator to remove element, so If the old way went wrong, the current way still goes wrong
@gong
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/IcebergSingleFileCommiter.java:
##########
@@ -316,9 +316,6 @@ private void commitUpToCheckpoint(NavigableMap<Long, byte[]> deltaManifestsMap,
}
continuousEmptyCheckpoints = 0;
}
- // remove already committed snapshot manifest info
-
- pendingMap.keySet().forEach(deltaManifestsMap::remove);
Review Comment:
this may be useless, because deltaManifestsMap is type `NavigableMap`， it's real type is `TreeMap`. The pendingMap is a view of treemap.
when call it's `clear()` it infact use iterator to remove element, so If the old way went wrong, the current way still goes wrong
@gong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org