[GitHub] [iceberg] nastra commented on a diff in pull request #6029: Replace Assert.fail usage with AssertJ fluent testing

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6029:
URL: https://github.com/apache/iceberg/pull/6029#discussion_r1001656153


##########
api/src/test/java/org/apache/iceberg/util/TestExceptionUtil.java:
##########
@@ -37,178 +34,110 @@ private CustomCheckedException(String message) {
   @Test
   public void testRunSafely() {
     CustomCheckedException exc = new CustomCheckedException("test");
-    try {

Review Comment:
   I have to admit that the original test code was quite difficult to read, so I tried to simplify it to the bare minimum



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org