[GitHub] [tez] ghanko commented on pull request #183: TEZ-4379 Tez Hive Queries query page rows does not go over

[GitBox <gi...@apache.org>]

ghanko commented on pull request #183:
URL: https://github.com/apache/tez/pull/183#issuecomment-1030869623


   > @ghanko , @csjuhasz-c: fix makes sense to me, however, it's not clear how could have paging worked in tez ui without this patch until now? anyway, have you been able to reproduce this and validate the fix?
   
   How it used to work is not clear to me either, but now we could reproduce the issue by feeding it with mock data as described in  the ticket. The result was exactly the same and after some debugging we found that the root cause is the `[].concat()` call as described here: https://github.com/emberjs/ember.js/issues/9843#issue-51376465
   
   The suggested fix of calling toArray() on the array being added didn't work because it wrapped the content elements to some other objects (probably a different version), but using the content property did fix the issue locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org