You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/29 19:56:45 UTC
[GitHub] [arrow-rs] tustvold opened a new issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
tustvold opened a new issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently there is no support for comparing FixedSizeBinaryArray
Describe the solution you'd like
It should be possible to call arrow::compute::eq_dyn, and friends with FixedSizeBinaryArray as arguments and have them not return an error. It may be possible to share code with the existing utf8 implementation.
Additional context
Encountered whilst implementing #1053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] xudong963 commented on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
xudong963 commented on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1063612519
> It's a nice job! I'm interested in this, I can take it up.
I noticed you are also interested in some other issues, I think if the issue is not explicitly assigned or someone explicitly says they are doing it, you can code after indicating you are going to start doing it, look forward to your PRs, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1012415570
This is a pretty good ticket for anyone who wants to mess with the compute kernels -- basically it should be add a small amount of code and a a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener removed a comment on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
jackwener removed a comment on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1064199950
@tustvold Hi, I'm newer and not familiar with project.
I found that PartialEq between `FixedSizeBinaryArray` and `scalar` isn't implemented.
I can't find the location of other DataType PartialEq with scalar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener commented on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1063608348
It's a nice job! I'm interested in this, I can take it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener commented on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1064199950
@tustvold Hi, I'm newer and not familiar with project.
I found that PartialEq between `FixedSizeBinaryArray` and `scalar` isn't implemented.
I can't find the location of other DataType PartialEq with scalar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jackwener commented on issue #1109: Add native comparison kernel support for FixedSizeBinaryArray
Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #1109:
URL: https://github.com/apache/arrow-rs/issues/1109#issuecomment-1063626884
> > It's a nice job! I'm interested in this, I can take it up.
>
> I noticed you are also interested in some other issues, I think if the issue is not explicitly assigned or someone explicitly says they are doing it, you can code after indicating you are going to start doing it, look forward to your PRs, thanks
Thanks for you remind and help😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org