[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1384: MINIFICPP-1885 Make non-core features disabled by default in the Windows installer

[GitBox <gi...@apache.org>]

fgerlits commented on code in PR #1384:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1384#discussion_r942595395


##########
win_build_vs.bat:
##########
@@ -66,6 +81,21 @@ for %%x in (%*) do (
     if [%%~x] EQU [/N]           set build_nanofi=ON
     if [%%~x] EQU [/O]           set build_opencv=ON
     if [%%~x] EQU [/PR]          set build_prometheus=ON
+    if [%%~x] EQU [/BUSTACHE]    set enable_bustache=ON
+    if [%%~x] EQU [/COAP]        set enable_coap=ON
+    if [%%~x] EQU [/ENCRYPT_CONFIG]   set enable_encrypt_config=ON
+    if [%%~x] EQU [/GPS]         set enable_gps=ON
+    if [%%~x] EQU [/LUA_SCRIPTING]    set enable_lua_scripting=ON
+    if [%%~x] EQU [/MQTT]        set enable_mqtt=ON
+    if [%%~x] EQU [/OPC]         set enable_opc=ON
+    if [%%~x] EQU [/OPENWSMAN]   set enable_openwsman=ON
+    if [%%~x] EQU [/OPS]         set enable_ops=ON
+    if [%%~x] EQU [/PCAP]        set enable_pcap=ON
+    if [%%~x] EQU [/PYTHON]      set enable_python=ON

Review Comment:
   good point, I've removed it in 5f4f51ae70eb6e6ff6b0f23e900fe192a5e7b5d3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org