You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2026/03/13 10:16:00 UTC

[PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

kgabryje opened a new pull request, #38628:
URL: https://github.com/apache/superset/pull/38628

   
   
   ### SUMMARY
     MCP chart tools (get_chart_info, get_chart_data, get_chart_preview) previously required a chart
     identifier (ID or UUID) even when a form_data_key was provided. This broke the workflow for unsaved/new
     charts in Explore, where no chart ID exists yet but the configuration is cached via form_data_key.
   
     This change makes the identifier field optional across all three tools when form_data_key is provided,
     and adds handling to query data, retrieve info, and render previews using only the cached form_data. A
     model validator ensures at least one of identifier or form_data_key is provided.
   
     Key changes:
     - Schemas: Made identifier optional (defaults to None) in GetChartInfoRequest, GetChartDataRequest, and
     GetChartPreviewRequest. Added model_validator to require at least one of identifier or form_data_key.
     Added form_data field to ChartInfo.
     - get_chart_info: Returns a minimal ChartInfo from cached form_data when no identifier is given.
     - get_chart_data: Extracts datasource/metrics/groupby from cached form_data and builds a query context
     to execute against the datasource directly via _query_from_form_data.
     - get_chart_preview: Creates a transient chart object (TransientChartFromKey) from cached form_data to
     render previews without a saved chart. Also adds form_data_key override support for saved charts.
     - Added event_logger context logging for unsaved chart and override paths.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
     1. Open Explore with a new unsaved chart (no chart ID in URL, only form_data_key)
     2. Use MCP get_chart_info with only form_data_key — should return chart config from cache
     3. Use MCP get_chart_data with only form_data_key — should return query results
     4. Use MCP get_chart_preview with only form_data_key — should render a preview
     5. Verify that providing both identifier and form_data_key still works (overrides saved state)
     6. Verify that providing neither returns a validation error
     7. Verify expired/invalid form_data_key returns appropriate error messages
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #38628:
URL: https://github.com/apache/superset/pull/38628#discussion_r2930311521


##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -109,9 +109,42 @@ async def get_chart_data(  # noqa: C901
         from superset.daos.chart import ChartDAO
         from superset.utils import json as utils_json
 
-        # Find the chart
+        chart = None
+
+        # Handle unsaved chart (form_data_key only, no identifier)
+        if not request.identifier and request.form_data_key:
+            with event_logger.log_context(
+                action="mcp.get_chart_data.unsaved_chart_from_cache"
+            ):
+                await ctx.info(
+                    "No chart identifier - querying data from unsaved chart cache: "
+                    "form_data_key=%s" % (request.form_data_key,)
+                )
+                cached_form_data = _get_cached_form_data(request.form_data_key)
+                if not cached_form_data:
+                    return ChartError(
+                        error="No cached chart data found for form_data_key. "
+                        "The cache may have expired.",
+                        error_type="NotFound",
+                    )
+                try:
+                    cached_form_data_dict = utils_json.loads(cached_form_data)
+                except (TypeError, ValueError) as e:
+                    return ChartError(
+                        error=f"Failed to parse cached form_data: {e}",
+                        error_type="ParseError",
+                    )
+                if not isinstance(cached_form_data_dict, dict):
+                    return ChartError(
+                        error="Cached form_data is not a valid JSON object.",
+                        error_type="ParseError",
+                    )
+
+                # Build query context entirely from cached form_data
+                return await _query_from_form_data(cached_form_data_dict, request, ctx)

Review Comment:
   **Suggestion:** When only `form_data_key` is provided, the function returns immediately and ignores non-JSON export requests, so callers asking for CSV/Excel get a JSON-shaped response instead of the requested format. Guard this path and return an explicit unsupported-format error (or implement conversion) to preserve API contract behavior. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Unsaved CSV/Excel requests return JSON-style payload unexpectedly.
   - ⚠️ Clients expecting export fields can mis-handle responses.
   ```
   </details>
   
   ```suggestion
                   # Build query context entirely from cached form_data
                   if request.format != "json":
                       return ChartError(
                           error=(
                               "Only json format is supported when using form_data_key "
                               "without a saved chart identifier."
                           ),
                           error_type="UnsupportedFormat",
                       )
                   return await _query_from_form_data(cached_form_data_dict, request, ctx)
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Send MCP `get_chart_data` request with only `form_data_key` and `format=\"csv\"` or
   `\"excel\"`; formats are explicitly allowed by schema in
   `superset/mcp_service/chart/schemas.py:1087-1088`.
   
   2. Request enters unsaved path in
   `superset/mcp_service/chart/tool/get_chart_data.py:115-144` and returns early at line 144
   before export conversion logic.
   
   3. Export conversion branches (`if request.format == "csv"` / `"excel"`) exist only later
   in saved-chart flow at `get_chart_data.py:654-669`, so they never run for this
   early-return path.
   
   4. `_query_from_form_data` returns regular `ChartData` rows (`get_chart_data.py:858+`) and
   does not populate export-specific `csv_data/excel_data/format` fields expected by
   `ChartData` model (`superset/mcp_service/chart/schemas.py:113-120`), causing
   response-shape mismatch for non-JSON callers.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_data.py
   **Line:** 143:144
   **Comment:**
   	*Logic Error: When only `form_data_key` is provided, the function returns immediately and ignores non-JSON export requests, so callers asking for CSV/Excel get a JSON-shaped response instead of the requested format. Guard this path and return an explicit unsupported-format error (or implement conversion) to preserve API contract behavior.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=b7543970b4ec0d2e641d10000beb3eb0a5fc622e245898bb4d5a3e999314b1c2&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=b7543970b4ec0d2e641d10000beb3eb0a5fc622e245898bb4d5a3e999314b1c2&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -707,6 +744,151 @@ async def get_chart_data(  # noqa: C901
         )
 
 
+async def _query_from_form_data(
+    form_data: Dict[str, Any],
+    request: GetChartDataRequest,
+    ctx: Context,
+) -> ChartData | ChartError:
+    """Query chart data using only cached form_data (no saved chart).
+
+    Used for unsaved charts where we only have form_data_key.
+    """
+    from superset.commands.chart.data.get_data_command import ChartDataCommand
+    from superset.common.query_context_factory import QueryContextFactory
+
+    datasource_id = form_data.get("datasource_id")
+    datasource_type: str = form_data.get("datasource_type") or "table"
+
+    # Handle combined datasource field (e.g., "1__table")
+    if not datasource_id and form_data.get("datasource"):
+        parts = str(form_data["datasource"]).split("__")
+        if len(parts) == 2:
+            datasource_id, datasource_type = parts[0], parts[1]
+
+    if not datasource_id:
+        return ChartError(
+            error="Cached form_data does not contain datasource information.",
+            error_type="InvalidFormData",
+        )
+
+    viz_type = form_data.get("viz_type", "unknown")
+    row_limit = (
+        request.limit or form_data.get("row_limit") or current_app.config["ROW_LIMIT"]
+    )
+
+    # Extract metrics and groupby based on chart type
+    if viz_type in ("big_number", "big_number_total", "pop_kpi"):
+        metric = form_data.get("metric")
+        metrics = [metric] if metric else []
+        groupby: list[str] = []
+    else:
+        metrics = form_data.get("metrics", [])
+        groupby = list(form_data.get("groupby") or [])
+

Review Comment:
   **Suggestion:** The unsaved-form-data metric/groupby extraction only handles three singular-metric chart types and otherwise assumes `metrics`+`groupby`, which breaks chart types like `world_map`, `treemap_v2`, `sunburst_v2`, `gauge_chart`, and `bubble` that use different fields. Expand extraction logic to include these known form_data patterns so query contexts are built correctly. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Unsaved world_map/treemap/sunburst/gauge/bubble queries can fail.
   - ⚠️ Unsaved results diverge from Explore chart configuration.
   ```
   </details>
   
   ```suggestion
       # Extract metrics and groupby based on chart type
       singular_metric_no_groupby = ("big_number", "big_number_total", "pop_kpi")
       singular_metric_types = (
           *singular_metric_no_groupby,
           "world_map",
           "treemap_v2",
           "sunburst_v2",
           "gauge_chart",
       )
   
       if viz_type == "bubble":
           metrics = [m for m in (form_data.get("x"), form_data.get("y"), form_data.get("size")) if m]
           groupby = list(form_data.get("groupby") or [])
           for field in (form_data.get("entity"), form_data.get("series")):
               if field and field not in groupby:
                   groupby.append(field)
       elif viz_type in singular_metric_types:
           metric = form_data.get("metric")
           metrics = [metric] if metric else []
           if viz_type in singular_metric_no_groupby:
               groupby = []
           else:
               groupby = list(form_data.get("groupby") or [])
               for field in (form_data.get("entity"), form_data.get("series")):
                   if field and field not in groupby:
                       groupby.append(field)
               for col in form_data.get("columns") or []:
                   if isinstance(col, str) and col not in groupby:
                       groupby.append(col)
       else:
           metrics = form_data.get("metrics", [])
           groupby = list(form_data.get("groupby") or [])
           if not groupby:
               for col in form_data.get("columns") or []:
                   if isinstance(col, str):
                       groupby.append(col)
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Invoke `get_chart_data` with `form_data_key` only (allowed by `GetChartDataRequest`
   validator at `superset/mcp_service/chart/schemas.py:1072-1075`), which routes into
   `_query_from_form_data` via `get_chart_data.py:115-144`.
   
   2. In `_query_from_form_data`, extraction logic at `get_chart_data.py:779-787` handles
   only `big_number/big_number_total/pop_kpi`; all other viz types default to `metrics` +
   `groupby`.
   
   3. For unsaved `world_map`, `treemap_v2`, `sunburst_v2`, `gauge_chart`, and `bubble`,
   form_data commonly uses `metric`/`entity`/`series`/`columns`/`x,y,size`; this mapping is
   already recognized in the same file's fallback logic (`get_chart_data.py:349-407`) and
   mirrored by dedicated tests in
   `tests/unit_tests/mcp_service/chart/tool/test_get_chart_data.py` (e.g., lines 69-75, 229+,
   272+, 321+, 11+ for bubble section).
   
   4. Because helper extraction misses those patterns, `QueryContextFactory.create(...)` at
   `get_chart_data.py:790-803` receives incomplete queries, causing failed/empty query
   outcomes (`EmptyQuery`/`NoData`) or incorrect unsaved-chart results.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_data.py
   **Line:** 779:787
   **Comment:**
   	*Logic Error: The unsaved-form-data metric/groupby extraction only handles three singular-metric chart types and otherwise assumes `metrics`+`groupby`, which breaks chart types like `world_map`, `treemap_v2`, `sunburst_v2`, `gauge_chart`, and `bubble` that use different fields. Expand extraction logic to include these known form_data patterns so query contexts are built correctly.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=5e2a3a4ce82047f9191fe9921300ac941dcfc3b012fbf6dfb3cdc3485a2c665b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=5e2a3a4ce82047f9191fe9921300ac941dcfc3b012fbf6dfb3cdc3485a2c665b&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -707,6 +744,151 @@ async def get_chart_data(  # noqa: C901
         )
 
 
+async def _query_from_form_data(
+    form_data: Dict[str, Any],
+    request: GetChartDataRequest,
+    ctx: Context,
+) -> ChartData | ChartError:
+    """Query chart data using only cached form_data (no saved chart).
+
+    Used for unsaved charts where we only have form_data_key.
+    """
+    from superset.commands.chart.data.get_data_command import ChartDataCommand
+    from superset.common.query_context_factory import QueryContextFactory
+
+    datasource_id = form_data.get("datasource_id")
+    datasource_type: str = form_data.get("datasource_type") or "table"
+
+    # Handle combined datasource field (e.g., "1__table")
+    if not datasource_id and form_data.get("datasource"):
+        parts = str(form_data["datasource"]).split("__")
+        if len(parts) == 2:
+            datasource_id, datasource_type = parts[0], parts[1]
+
+    if not datasource_id:
+        return ChartError(
+            error="Cached form_data does not contain datasource information.",
+            error_type="InvalidFormData",
+        )
+
+    viz_type = form_data.get("viz_type", "unknown")
+    row_limit = (
+        request.limit or form_data.get("row_limit") or current_app.config["ROW_LIMIT"]
+    )
+
+    # Extract metrics and groupby based on chart type
+    if viz_type in ("big_number", "big_number_total", "pop_kpi"):
+        metric = form_data.get("metric")
+        metrics = [metric] if metric else []
+        groupby: list[str] = []
+    else:
+        metrics = form_data.get("metrics", [])
+        groupby = list(form_data.get("groupby") or [])
+
+    try:
+        factory = QueryContextFactory()
+        query_context = factory.create(
+            datasource={"id": datasource_id, "type": datasource_type},
+            queries=[
+                {
+                    "filters": form_data.get("filters", []),
+                    "columns": groupby,
+                    "metrics": metrics,
+                    "row_limit": row_limit,
+                    "order_desc": form_data.get("order_desc", True),
+                }
+            ],
+            form_data=form_data,
+            force=request.force_refresh,
+        )
+
+        await ctx.report_progress(3, 4, "Executing data query")
+        with event_logger.log_context(action="mcp.get_chart_data.query_execution"):
+            command = ChartDataCommand(query_context)
+            result = command.run()

Review Comment:
   **Suggestion:** The unsaved-chart query path runs `ChartDataCommand` without calling `validate()`, which skips the standard access/validation gate used everywhere else before query execution. Add `command.validate()` before `run()` so permission and datasource checks are enforced consistently. [security]
   
   <details>
   <summary><b>Severity Level:</b> Critical 🚨</summary>
   
   ```mdx
   - ❌ Unsaved data queries skip `raise_for_access` authorization check.
   - ⚠️ Security behavior differs from other chart query paths.
   ```
   </details>
   
   ```suggestion
           with event_logger.log_context(action="mcp.get_chart_data.query_execution"):
               command = ChartDataCommand(query_context)
               command.validate()
               result = command.run()
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Call MCP tool `get_chart_data` (registered in `superset/mcp_service/app.py:34-38`) with
   `form_data_key` only; request is accepted by `GetChartDataRequest` validator in
   `superset/mcp_service/chart/schemas.py:1072-1075`.
   
   2. Execution enters unsaved fast path in
   `superset/mcp_service/chart/tool/get_chart_data.py:115-144` and immediately delegates to
   `_query_from_form_data(...)`.
   
   3. In `_query_from_form_data`, query execution at
   `superset/mcp_service/chart/tool/get_chart_data.py:806-808` creates `ChartDataCommand` and
   calls `run()` directly.
   
   4. `ChartDataCommand.validate()` is the method that enforces access
   (`superset/commands/chart/data/get_data_command.py:72-73` calling
   `QueryContext.raise_for_access()`), while `run()` (`.../get_data_command.py:40-70`) does
   not perform that check, so this path skips the standard authorization gate used by
   saved-chart path (`get_chart_data.py:501-503`) and preview flows
   (`get_chart_preview.py:162-164`, `237-239`, `344-346`).
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_data.py
   **Line:** 806:808
   **Comment:**
   	*Security: The unsaved-chart query path runs `ChartDataCommand` without calling `validate()`, which skips the standard access/validation gate used everywhere else before query execution. Add `command.validate()` before `run()` so permission and datasource checks are enforced consistently.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=846158fb767b4da015a49cf56c677d49aaca3aa98c7bdc37309ca0471db5a8e0&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=846158fb767b4da015a49cf56c677d49aaca3aa98c7bdc37309ca0471db5a8e0&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_info.py:
##########
@@ -56,6 +56,60 @@ def _get_cached_form_data(form_data_key: str) -> str | None:
         return None
 
 
+def _build_unsaved_chart_info(form_data_key: str) -> ChartInfo | ChartError:
+    """Build a ChartInfo from cached form_data when no chart identifier exists."""
+    from superset.utils import json as utils_json
+
+    cached_form_data = _get_cached_form_data(form_data_key)
+    if not cached_form_data:
+        return ChartError(
+            error="No cached chart data found for form_data_key. "
+            "The cache may have expired.",
+            error_type="NotFound",
+        )
+    try:
+        form_data = utils_json.loads(cached_form_data)
+    except (TypeError, ValueError) as e:
+        return ChartError(
+            error=f"Failed to parse cached form_data: {e}",
+            error_type="ParseError",
+        )
+    return ChartInfo(
+        viz_type=form_data.get("viz_type"),
+        datasource_name=form_data.get("datasource_name"),
+        datasource_type=form_data.get("datasource_type"),
+        form_data=form_data,
+        form_data_key=form_data_key,
+        is_unsaved_state=True,
+    )

Review Comment:
   **Suggestion:** `utils_json.loads` can return non-dict JSON (e.g., list/null), but the code immediately calls `.get(...)` on it. That will raise `AttributeError` and return a 500 instead of a structured `ChartError`. Add a type check after parsing and return a parse error when the payload is not a JSON object. [type error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Unsaved `get_chart_info` can fail with internal ToolError.
   - ⚠️ MCP chart-inspection flow breaks for malformed cached payloads.
   ```
   </details>
   
   ```suggestion
       try:
           form_data = utils_json.loads(cached_form_data)
       except (TypeError, ValueError) as e:
           return ChartError(
               error=f"Failed to parse cached form_data: {e}",
               error_type="ParseError",
           )
   
       if not isinstance(form_data, dict):
           return ChartError(
               error="Cached form_data is not a valid JSON object.",
               error_type="ParseError",
           )
   
       return ChartInfo(
           viz_type=form_data.get("viz_type"),
           datasource_name=form_data.get("datasource_name"),
           datasource_type=form_data.get("datasource_type"),
           form_data=form_data,
           form_data_key=form_data_key,
           is_unsaved_state=True,
       )
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Create cached form data with valid-but-non-object JSON via Explore form-data API:
   `ExploreFormDataRestApi.post()` in `superset/explore/form_data/api.py:50-106` accepts
   `form_data` as generic string (`superset/explore/form_data/schemas.py:33-37`), so payload
   like `"null"` or `"[]"` is allowed.
   
   2. Persistence path validates syntax only: `CreateFormDataCommand.validate()`
   (`superset/commands/explore/form_data/create.py:74-76`) calls `validate_json`, which only
   runs `loads` (`superset/utils/json.py:50-53`) and does not enforce dict/object shape.
   
   3. Call MCP tool `get_chart_info` with only `form_data_key` (tool registered through
   `superset/mcp_service/app.py:10-14`); execution enters unsaved branch in
   `superset/mcp_service/chart/tool/get_chart_info.py:159-168`, then
   `_build_unsaved_chart_info()`.
   
   4. In `_build_unsaved_chart_info` (`get_chart_info.py:70-84`), `utils_json.loads` returns
   `None`/list, then `form_data.get(...)` at lines `78-80` raises `AttributeError`; this is
   converted by global middleware (`superset/mcp_service/middleware.py:109-116`) into a
   generic internal ToolError instead of structured `ChartError(ParseError)`.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_info.py
   **Line:** 70:84
   **Comment:**
   	*Type Error: `utils_json.loads` can return non-dict JSON (e.g., list/null), but the code immediately calls `.get(...)` on it. That will raise `AttributeError` and return a 500 instead of a structured `ChartError`. Add a type check after parsing and return a parse error when the payload is not a JSON object.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=48c175bbc35bfbcaafaca3618af28dbd98981a5a4a7200e04d74fe71057cf327&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=48c175bbc35bfbcaafaca3618af28dbd98981a5a4a7200e04d74fe71057cf327&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_info.py:
##########
@@ -56,6 +56,60 @@ def _get_cached_form_data(form_data_key: str) -> str | None:
         return None
 
 
+def _build_unsaved_chart_info(form_data_key: str) -> ChartInfo | ChartError:
+    """Build a ChartInfo from cached form_data when no chart identifier exists."""
+    from superset.utils import json as utils_json
+
+    cached_form_data = _get_cached_form_data(form_data_key)
+    if not cached_form_data:
+        return ChartError(
+            error="No cached chart data found for form_data_key. "
+            "The cache may have expired.",
+            error_type="NotFound",
+        )
+    try:
+        form_data = utils_json.loads(cached_form_data)
+    except (TypeError, ValueError) as e:
+        return ChartError(
+            error=f"Failed to parse cached form_data: {e}",
+            error_type="ParseError",
+        )
+    return ChartInfo(
+        viz_type=form_data.get("viz_type"),
+        datasource_name=form_data.get("datasource_name"),
+        datasource_type=form_data.get("datasource_type"),
+        form_data=form_data,
+        form_data_key=form_data_key,
+        is_unsaved_state=True,
+    )
+
+
+def _apply_unsaved_state_override(result: ChartInfo, form_data_key: str) -> None:
+    """Override a ChartInfo's form_data with cached unsaved state."""
+    from superset.utils import json as utils_json
+
+    if cached_form_data := _get_cached_form_data(form_data_key):
+        try:
+            result.form_data = utils_json.loads(cached_form_data)
+            result.form_data_key = form_data_key
+            result.is_unsaved_state = True
+
+            # Update viz_type from cached form_data if present
+            if result.form_data and "viz_type" in result.form_data:
+                result.viz_type = result.form_data["viz_type"]

Review Comment:
   **Suggestion:** The unsaved-state override only updates `viz_type`, leaving datasource metadata from the saved chart even when cached unsaved form data changed datasource fields. This returns inconsistent chart info (mixed saved/unsaved state). Update datasource fields from cached form data during override. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ `get_chart_info` may return mixed saved/unsaved chart metadata.
   - ⚠️ MCP agents can reason from stale datasource fields.
   ```
   </details>
   
   ```suggestion
               result.form_data = utils_json.loads(cached_form_data)
               result.form_data_key = form_data_key
               result.is_unsaved_state = True
   
               if isinstance(result.form_data, dict):
                   # Update key metadata fields to match unsaved state
                   if "viz_type" in result.form_data:
                       result.viz_type = result.form_data["viz_type"]
                   if "datasource_name" in result.form_data:
                       result.datasource_name = result.form_data["datasource_name"]
                   if "datasource_type" in result.form_data:
                       result.datasource_type = result.form_data["datasource_type"]
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Use normal saved-chart path by calling MCP `get_chart_info` with both `identifier` and
   `form_data_key`; code enters lookup flow
   (`superset/mcp_service/chart/tool/get_chart_info.py:181-205`) and applies unsaved
   override.
   
   2. Base metadata comes from saved Slice serialization (`serialize_chart_object` sets
   `datasource_name`/`datasource_type` from chart attributes in
   `superset/mcp_service/chart/schemas.py:213-219`).
   
   3. Override logic `_apply_unsaved_state_override()` (`get_chart_info.py:87-100`) sets
   `form_data` and updates only `viz_type`, leaving datasource metadata untouched even when
   cached unsaved form_data contains datasource fields.
   
   4. Response can therefore contain mixed state: `form_data` reflects unsaved edits while
   top-level datasource metadata remains saved-chart metadata, creating inconsistent tool
   output for clients consuming top-level fields.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_info.py
   **Line:** 93:99
   **Comment:**
   	*Logic Error: The unsaved-state override only updates `viz_type`, leaving datasource metadata from the saved chart even when cached unsaved form data changed datasource fields. This returns inconsistent chart info (mixed saved/unsaved state). Update datasource fields from cached form data during override.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=b4a8f486c660c026e93455e3409151b88616e3e82bcafc910a031da51994c4ec&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=b4a8f486c660c026e93455e3409151b88616e3e82bcafc910a031da51994c4ec&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_preview.py:
##########
@@ -1837,7 +1837,71 @@ async def _get_chart_preview_internal(  # noqa: C901
         # Find the chart
         with event_logger.log_context(action="mcp.get_chart_preview.chart_lookup"):
             chart: Any = None
-            if isinstance(request.identifier, int) or (
+
+            # Handle unsaved chart (form_data_key only, no identifier)
+            if not request.identifier and request.form_data_key:
+                with event_logger.log_context(
+                    action="mcp.get_chart_preview.unsaved_chart_from_cache"
+                ):
+                    await ctx.info(
+                        "No chart identifier - creating transient chart from "
+                        "form_data_key=%s" % (request.form_data_key,)
+                    )
+                    from superset.commands.explore.form_data.get import (
+                        GetFormDataCommand,
+                    )
+                    from superset.commands.explore.form_data.parameters import (
+                        CommandParameters,
+                    )
+                    from superset.utils import json as utils_json
+
+                    try:
+                        cmd_params = CommandParameters(key=request.form_data_key)
+                        form_data_json = GetFormDataCommand(cmd_params).run()
+                        if form_data_json:
+                            form_data = utils_json.loads(form_data_json)
+
+                            class TransientChartFromKey:
+                                def __init__(self, fd: Dict[str, Any]):
+                                    self.id = None

Review Comment:
   **Suggestion:** The unsaved-chart transient object sets the identifier to `None`, but the response schema requires an integer chart id. This causes response construction to fail at runtime for form_data_key-only previews. Use a numeric sentinel id for transient charts so the response can be serialized. [type error]
   
   <details>
   <summary><b>Severity Level:</b> Critical 🚨</summary>
   
   ```mdx
   - ❌ form_data_key-only preview returns InternalError instead of preview.
   - ⚠️ Unsaved Explore preview workflow becomes unusable.
   ```
   </details>
   
   ```suggestion
                                       self.id = 0
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Call MCP tool `get_chart_preview` (entrypoint
   `superset/mcp_service/chart/tool/get_chart_preview.py:2193`) with `form_data_key` only
   (allowed by validator in `superset/mcp_service/chart/schemas.py:1184-1189`) and a
   non-`url` format like `table`.
   
   2. Request flows into `_get_chart_preview_internal` (`get_chart_preview.py:1815`), unsaved
   branch (`1842`), and builds `TransientChartFromKey` with `self.id = None` (`1866`).
   
   3. After preview content generation, response model is built at `ChartPreview(...)`
   (`get_chart_preview.py:2123`) using `chart_id=chart.id`; schema requires `chart_id: int`
   (`schemas.py:1334-1338`).
   
   4. Pydantic validation fails on `None` chart_id, caught by outer exception handler
   (`get_chart_preview.py:2160+`), returning `ChartError(InternalError)` instead of
   successful preview.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_preview.py
   **Line:** 1866:1866
   **Comment:**
   	*Type Error: The unsaved-chart transient object sets the identifier to `None`, but the response schema requires an integer chart id. This causes response construction to fail at runtime for form_data_key-only previews. Use a numeric sentinel id for transient charts so the response can be serialized.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=a64184f5262d1e1a2bc52b972839f3707cb9204eccb2d0ade99e2678cbb33978&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=a64184f5262d1e1a2bc52b972839f3707cb9204eccb2d0ade99e2678cbb33978&reaction=dislike'>👎</a>



##########
superset/mcp_service/chart/tool/get_chart_preview.py:
##########
@@ -1951,6 +2015,48 @@ def __init__(self, form_data: Dict[str, Any]):
             for warning in validation_result.warnings:
                 await ctx.warning("Dataset warning: %s" % (warning,))
 
+        # If form_data_key is provided, override chart.params with cached
+        # form_data so the preview reflects what the user actually sees
+        if request.form_data_key and getattr(chart, "id", None) is not None:
+            with event_logger.log_context(
+                action="mcp.get_chart_preview.unsaved_state_override"
+            ):
+                await ctx.info(
+                    "Retrieving unsaved chart state from cache: form_data_key=%s"
+                    % (request.form_data_key,)
+                )
+                from superset.commands.explore.form_data.get import (
+                    GetFormDataCommand,
+                )
+                from superset.commands.explore.form_data.parameters import (
+                    CommandParameters,
+                )
+
+                try:
+                    cmd_params = CommandParameters(key=request.form_data_key)
+                    cached_form_data = GetFormDataCommand(cmd_params).run()
+                    if cached_form_data:
+                        chart.params = cached_form_data
+                        from superset.utils import json as utils_json
+
+                        parsed = utils_json.loads(cached_form_data)
+                        if isinstance(parsed, dict) and "viz_type" in parsed:
+                            chart.viz_type = parsed["viz_type"]

Review Comment:
   **Suggestion:** The unsaved-state override updates only `params` and optionally `viz_type`, but preview queries use `chart.datasource_id`/`chart.datasource_type`. If users changed datasource in Explore, preview generation still queries the saved datasource and can return wrong data or fail. Update datasource fields from cached form_data during override. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Critical 🚨</summary>
   
   ```mdx
   - ❌ Preview may show data from wrong datasource.
   - ⚠️ Unsaved datasource edits can trigger preview query errors.
   ```
   </details>
   
   ```suggestion
                           parsed = utils_json.loads(cached_form_data)
                           if isinstance(parsed, dict):
                               if "viz_type" in parsed:
                                   chart.viz_type = parsed["viz_type"]
   
                               datasource = parsed.get("datasource")
                               if isinstance(datasource, str) and "__" in datasource:
                                   ds_id, ds_type = datasource.split("__", 1)
                                   if ds_id.isdigit():
                                       chart.datasource_id = int(ds_id)
                                       chart.datasource_type = ds_type
                               else:
                                   if parsed.get("datasource_id") is not None:
                                       chart.datasource_id = int(parsed["datasource_id"])
                                   if parsed.get("datasource_type"):
                                       chart.datasource_type = parsed["datasource_type"]
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Call `get_chart_preview` with both `identifier` and `form_data_key` (override path at
   `get_chart_preview.py:2020`) after changing datasource in Explore unsaved state.
   
   2. Override block loads cached form_data but only sets `chart.params` and maybe
   `chart.viz_type` (`2039-2044`), leaving `chart.datasource_id/type` from saved chart.
   
   3. Preview strategies build query context from `self.chart.datasource_id/type` (e.g.,
   Table strategy `219-223`, ASCII strategy `149-152`) while using unsaved params.
   
   4. Query runs against old datasource with new-form fields, producing wrong preview data or
   query failures (returned as `TableError`/`ASCIIError`).
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/mcp_service/chart/tool/get_chart_preview.py
   **Line:** 2042:2044
   **Comment:**
   	*Logic Error: The unsaved-state override updates only `params` and optionally `viz_type`, but preview queries use `chart.datasource_id`/`chart.datasource_type`. If users changed datasource in Explore, preview generation still queries the saved datasource and can return wrong data or fail. Update datasource fields from cached form_data during override.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=201a62eeeb1248f419bc820963c331e8abff67fd15ab05ba6d4152452f128439&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38628&comment_hash=201a62eeeb1248f419bc820963c331e8abff67fd15ab05ba6d4152452f128439&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #38628:
URL: https://github.com/apache/superset/pull/38628#discussion_r2930377761


##########
superset/mcp_service/chart/tool/get_chart_info.py:
##########
@@ -96,13 +155,28 @@ async def get_chart_info(
     """
     from superset.daos.chart import ChartDAO
     from superset.models.slice import Slice
-    from superset.utils import json as utils_json
 
     await ctx.info(
         "Retrieving chart information: identifier=%s, form_data_key=%s"
         % (request.identifier, request.form_data_key)
     )
 
+    # Handle unsaved chart (form_data_key only, no identifier)
+    if not request.identifier and request.form_data_key:
+        with event_logger.log_context(
+            action="mcp.get_chart_info.unsaved_chart_from_cache"
+        ):
+            await ctx.info(
+                "No chart identifier provided - retrieving unsaved chart from cache: "
+                "form_data_key=%s" % (request.form_data_key,)
+            )
+            return _build_unsaved_chart_info(request.form_data_key)

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Use of assert statement detected</b></div>
   <div id="fix">
   
   Replace `assert` statement on line 173 with proper error handling. Assertions can be disabled at runtime and should not be used for runtime validation.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ````suggestion
       # At this point identifier must be set (validator ensures at least one
       # of identifier/form_data_key is provided, and the form_data_key-only
       # branch returned above).
       if request.identifier is None:
           raise ValueError("Chart identifier must be provided when form_data_key is not supplied")
   ````
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #734860</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38628:
URL: https://github.com/apache/superset/pull/38628#issuecomment-4054069389

   ## **Sequence Diagram**
   
   This PR allows get_chart_info, get_chart_data, and get_chart_preview to work when no chart identifier exists, as long as a form data key is provided. It also supports overriding saved chart state with cached unsaved form data, while enforcing that at least one of identifier or form data key is present.
   
   ```mermaid
   sequenceDiagram
       participant Client
       participant MCPChartTools
       participant RequestSchema
       participant FormDataCache
       participant ChartStore
       participant ChartEngine
   
       Client->>MCPChartTools: Request chart info data or preview
       MCPChartTools->>RequestSchema: Validate identifier or form data key
   
       alt Form data key only
           MCPChartTools->>FormDataCache: Load cached form data
           MCPChartTools->>ChartEngine: Build response from cached form data
           ChartEngine-->>Client: Return unsaved chart info data or preview
       else Identifier provided
           MCPChartTools->>ChartStore: Load saved chart by id or uuid
           opt Form data key also provided
               MCPChartTools->>FormDataCache: Load cached form data override
           end
           MCPChartTools->>ChartEngine: Build response from saved or overridden state
           ChartEngine-->>Client: Return chart info data or preview
       end
   ```
   
   ---
   *Generated by [CodeAnt AI](https://codeant.ai)*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38628:
URL: https://github.com/apache/superset/pull/38628#issuecomment-4054128833

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38628?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `7.10059%` with `157 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.99%. Comparing base ([`95f61bd`](https://app.codecov.io/gh/apache/superset/commit/95f61bd223ee7f72893197c77ec73a06d225443b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`329e25b`](https://app.codecov.io/gh/apache/superset/commit/329e25be12f4de240fc5b88c941fe920eadc6d93?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 7 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/38628?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/mcp\_service/chart/tool/get\_chart\_data.py](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Ftool%2Fget_chart_data.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdG9vbC9nZXRfY2hhcnRfZGF0YS5weQ==) | 1.35% | [73 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...perset/mcp\_service/chart/tool/get\_chart\_preview.py](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Ftool%2Fget_chart_preview.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdG9vbC9nZXRfY2hhcnRfcHJldmlldy5weQ==) | 0.00% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/mcp\_service/chart/tool/get\_chart\_info.py](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Ftool%2Fget_chart_info.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdG9vbC9nZXRfY2hhcnRfaW5mby5weQ==) | 6.66% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/mcp\_service/chart/schemas.py](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Fschemas.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvc2NoZW1hcy5weQ==) | 50.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/38628?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #38628       +/-   ##
   ===========================================
   - Coverage   65.01%   54.99%   -10.03%     
   ===========================================
     Files        1817     2529      +712     
     Lines       72318   129105    +56787     
     Branches    23032    29746     +6714     
   ===========================================
   + Hits        47016    70996    +23980     
   - Misses      25302    57776    +32474     
   - Partials        0      333      +333     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/38628/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/38628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.66% <7.10%> (?)` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/38628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.68% <7.10%> (?)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/38628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.20% <7.10%> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/38628/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38628?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38628:
URL: https://github.com/apache/superset/pull/38628#issuecomment-4054063387

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #38628:
URL: https://github.com/apache/superset/pull/38628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(mcp): Support form_data_key without chart identifier for unsaved charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38628:
URL: https://github.com/apache/superset/pull/38628#issuecomment-4054393333

   **Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org