You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/17 03:40:02 UTC
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17754: docs: update contribuing docs
zhaoyongjie commented on a change in pull request #17754:
URL: https://github.com/apache/superset/pull/17754#discussion_r771084085
##########
File path: CONTRIBUTING.md
##########
@@ -728,7 +715,7 @@ def sqrt(x: Union[float, int]) -> Union[float, int]:
return math.sqrt(x)
```
-### TypeScript
+### TypeScript Typing
Review comment:
The `Typescript in Linting` and `Typescript in Typescript` are in conflict, so the Table of Contents isn't `typescript` in `Linting` section
<img width="618" alt="image" src="https://user-images.githubusercontent.com/2016594/146484690-c0375b13-2caa-41d0-9708-342ef8fbd06c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org