You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Eric Bléher (Jira)" <ji...@apache.org> on 2020/04/09 09:31:00 UTC

[jira] [Comment Edited] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

    [ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079105#comment-17079105 ] 

Eric Bléher edited comment on THRIFT-5173 at 4/9/20, 9:30 AM:
--------------------------------------------------------------

why having a method virtual would impact performance? This gives some hints:

[https://softwareengineering.stackexchange.com/questions/234473/how-are-virtual-methods-slower-in-c]

 


was (Author: ericbl):
why having a method virtual would impact performance?

> Thrift C# (netstd) code generator: make method virtual for mocking
> ------------------------------------------------------------------
>
>                 Key: THRIFT-5173
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5173
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>    Affects Versions: 0.13.0
>            Reporter: Eric Bléher
>            Priority: Major
>
> Thrift compiler generates C# clients where methods cannot be mocked because they are not defined as virtual.
> Adding virtual allow the usage of Moq and thus I can have proper unit tests of my own class implementations consuming theses generated clients.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)