You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/06 12:28:23 UTC

[GitHub] [pulsar] cbornet opened a new pull request, #15042: Add pulsar_subscription_consumers_count metric

cbornet opened a new pull request, #15042:
URL: https://github.com/apache/pulsar/pull/15042

   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   Fixes #15032
   
   ### Modifications
   
   Added metric `pulsar_subscription_consumers_count`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   
   This change added tests and can be verified as follows:
   
   Run `PrometheusMetricsTest::testNonPersistentSubMetrics`
   
   ### Does this pull request potentially affect one of the following parts:
   
   no
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
   
   There are other undocumented subscription metrics. Should document all of them in another PR ?
   
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15042:
URL: https://github.com/apache/pulsar/pull/15042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15042:
URL: https://github.com/apache/pulsar/pull/15042#issuecomment-1112804033

   #### Doc status update
   @cbornet will submit a PR to add docs soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #15042:
URL: https://github.com/apache/pulsar/pull/15042#issuecomment-1090211591

   Alternative PR to #15041 for discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #15042:
URL: https://github.com/apache/pulsar/pull/15042#issuecomment-1090294583

   Had to do a fix for when consumer metrics are not enabled. Can you review again ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15042:
URL: https://github.com/apache/pulsar/pull/15042#issuecomment-1107991076

   ping @momo-jun for providing help on docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15042: Add pulsar_subscription_consumers_count metric

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15042:
URL: https://github.com/apache/pulsar/pull/15042#issuecomment-1108002883

   Hi @cbornet, will you like to submit a follow-up PR to add docs? Let us know your plan or any other assistance you need.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org