You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/07/02 17:00:47 UTC

[PR] [opt](function) opt function coalesce by spik null column [doris]

Mryange opened a new pull request, #36953:
URL: https://github.com/apache/doris/pull/36953

   ## Proposed changes
   before
   ```
   mysql [test]>select count(coalesce(null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, i1, null)) from half_null;
   +---------------------------------------------------------------------------------------------------------------------+
   | count(coalesce(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, i1, NULL)) |
   +---------------------------------------------------------------------------------------------------------------------+
   |                                                                                                            20000000 |
   +---------------------------------------------------------------------------------------------------------------------+
   1 row in set (1.44 sec)
   ```
   now
   ```
   mysql [test]>select count(coalesce(null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, i1, null)) from half_null;
   +---------------------------------------------------------------------------------------------------------------------+
   | count(coalesce(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, i1, NULL)) |
   +---------------------------------------------------------------------------------------------------------------------+
   |                                                                                                            20000000 |
   +---------------------------------------------------------------------------------------------------------------------+
   1 row in set (0.19 sec)
   ```
   
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194571202

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194654275

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174385 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 52592a274df7c29ef11f6c60565f02d7870797a9, data reload: false
   
   query1	916	374	370	370
   query2	6531	2386	2317	2317
   query3	6648	205	212	205
   query4	18887	17374	17348	17348
   query5	4284	498	476	476
   query6	267	173	157	157
   query7	4599	303	295	295
   query8	327	322	289	289
   query9	8447	2434	2430	2430
   query10	623	307	286	286
   query11	10633	10171	9893	9893
   query12	131	88	84	84
   query13	1656	383	369	369
   query14	9550	7786	7675	7675
   query15	265	191	201	191
   query16	7972	276	271	271
   query17	1904	563	548	548
   query18	2031	278	281	278
   query19	199	156	158	156
   query20	89	85	85	85
   query21	222	129	128	128
   query22	4361	4263	4135	4135
   query23	33763	33167	33171	33167
   query24	11499	2839	2798	2798
   query25	657	377	385	377
   query26	1614	156	154	154
   query27	2940	319	325	319
   query28	7413	2114	2100	2100
   query29	1045	643	637	637
   query30	294	154	152	152
   query31	965	722	743	722
   query32	102	57	59	57
   query33	796	318	311	311
   query34	915	475	493	475
   query35	748	669	655	655
   query36	1099	944	917	917
   query37	164	71	74	71
   query38	2913	2748	2759	2748
   query39	883	814	782	782
   query40	280	127	127	127
   query41	56	54	54	54
   query42	124	96	101	96
   query43	608	547	546	546
   query44	1223	739	744	739
   query45	197	172	169	169
   query46	1092	712	736	712
   query47	1836	1768	1762	1762
   query48	378	311	305	305
   query49	1196	431	444	431
   query50	773	391	407	391
   query51	6954	6865	6749	6749
   query52	115	90	103	90
   query53	359	304	293	293
   query54	905	464	451	451
   query55	78	76	76	76
   query56	305	279	284	279
   query57	1161	1056	1071	1056
   query58	282	240	266	240
   query59	3347	3122	3387	3122
   query60	305	279	271	271
   query61	107	107	89	89
   query62	653	460	453	453
   query63	321	295	297	295
   query64	9854	2211	1779	1779
   query65	3304	3145	3103	3103
   query66	1381	354	325	325
   query67	15863	14971	14861	14861
   query68	9136	575	589	575
   query69	669	486	431	431
   query70	1395	1109	1148	1109
   query71	512	270	293	270
   query72	8875	5561	5492	5492
   query73	2240	324	323	323
   query74	5890	5481	5545	5481
   query75	5555	2677	2668	2668
   query76	5473	1047	984	984
   query77	729	313	314	313
   query78	10703	9800	10127	9800
   query79	8923	535	529	529
   query80	901	460	470	460
   query81	551	224	224	224
   query82	228	102	101	101
   query83	341	168	164	164
   query84	265	88	82	82
   query85	935	282	269	269
   query86	353	300	318	300
   query87	3322	3084	3080	3080
   query88	4410	2429	2372	2372
   query89	488	379	380	379
   query90	1922	185	186	185
   query91	134	97	100	97
   query92	65	48	47	47
   query93	5390	526	512	512
   query94	1371	183	185	183
   query95	405	313	312	312
   query96	607	279	277	277
   query97	3215	3049	3061	3049
   query98	219	212	200	200
   query99	1245	834	825	825
   Total cold run time: 297876 ms
   Total hot run time: 174385 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194617703

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39864 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 52592a274df7c29ef11f6c60565f02d7870797a9, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17910	4726	4352	4352
   q2	2657	193	193	193
   q3	11625	1191	1131	1131
   q4	10340	774	799	774
   q5	7677	2675	2736	2675
   q6	226	143	139	139
   q7	960	610	618	610
   q8	9257	2060	2045	2045
   q9	8902	6434	6434	6434
   q10	8969	3708	3730	3708
   q11	446	244	237	237
   q12	422	236	229	229
   q13	18148	3003	3024	3003
   q14	262	224	214	214
   q15	547	482	487	482
   q16	496	380	374	374
   q17	966	764	712	712
   q18	7981	7481	7287	7287
   q19	7019	1434	1495	1434
   q20	643	320	332	320
   q21	4954	3170	3855	3170
   q22	399	342	341	341
   Total cold run time: 120806 ms
   Total hot run time: 39864 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4379	4301	4202	4202
   q2	388	274	271	271
   q3	3011	2762	2761	2761
   q4	1855	1548	1570	1548
   q5	5274	5252	5308	5252
   q6	217	128	129	128
   q7	2103	1776	1741	1741
   q8	3200	3328	3314	3314
   q9	8361	8282	8345	8282
   q10	3837	3673	3705	3673
   q11	590	495	484	484
   q12	808	609	580	580
   q13	17502	3012	3004	3004
   q14	308	270	256	256
   q15	512	479	469	469
   q16	458	421	420	420
   q17	1760	1472	1485	1472
   q18	7672	7499	7344	7344
   q19	1665	1584	1605	1584
   q20	1971	1827	1798	1798
   q21	4824	4738	4813	4738
   q22	622	551	575	551
   Total cold run time: 71317 ms
   Total hot run time: 53872 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #36953: [opt](function) opt function coalesce by spik null column
URL: https://github.com/apache/doris/pull/36953


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194666269

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.65 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 52592a274df7c29ef11f6c60565f02d7870797a9, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.68	0.07	0.07
   query5	0.47	0.49	0.48
   query6	1.14	0.72	0.73
   query7	0.02	0.01	0.02
   query8	0.05	0.05	0.04
   query9	0.55	0.50	0.47
   query10	0.56	0.55	0.55
   query11	0.15	0.11	0.11
   query12	0.15	0.11	0.12
   query13	0.59	0.58	0.60
   query14	0.77	0.78	0.78
   query15	0.84	0.81	0.81
   query16	0.36	0.36	0.36
   query17	1.00	1.02	1.06
   query18	0.20	0.25	0.25
   query19	1.82	1.73	1.65
   query20	0.01	0.01	0.01
   query21	15.46	0.76	0.65
   query22	4.41	6.79	2.01
   query23	18.32	1.43	1.30
   query24	2.11	0.23	0.21
   query25	0.14	0.09	0.08
   query26	0.26	0.19	0.18
   query27	0.08	0.08	0.07
   query28	13.28	1.02	1.00
   query29	12.60	3.37	3.39
   query30	0.25	0.06	0.06
   query31	2.87	0.39	0.39
   query32	3.27	0.46	0.47
   query33	2.85	2.91	2.89
   query34	17.04	4.40	4.38
   query35	4.45	4.42	4.50
   query36	0.64	0.47	0.47
   query37	0.18	0.15	0.15
   query38	0.14	0.13	0.14
   query39	0.04	0.04	0.03
   query40	0.18	0.14	0.15
   query41	0.10	0.05	0.04
   query42	0.05	0.05	0.04
   query43	0.04	0.04	0.04
   Total cold run time: 109.46 s
   Total hot run time: 30.65 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194570306

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [opt](function) opt function coalesce by spik null column [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36953:
URL: https://github.com/apache/doris/pull/36953#issuecomment-2194580934

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org