You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2016/02/18 20:40:21 UTC

Review Request 43733: Remove targeted orchestration for patches

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-15097
    https://issues.apache.org/jira/browse/AMBARI-15097


Repository: ambari


Description
-------

Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.

Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
  ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
  ambari-server/src/main/resources/version_definition.xsd 42035de 
  ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
  ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/43733/diff/


Testing
-------

Manual.  Automated pending.


Thanks,

Nate Cole


Re: Review Request 43733: Remove targeted orchestration for patches

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/#review119707
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 18, 2016, 7:40 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43733/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:40 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15097
>     https://issues.apache.org/jira/browse/AMBARI-15097
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.
> 
> Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
>   ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
>   ambari-server/src/main/resources/version_definition.xsd 42035de 
>   ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
>   ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43733/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 43733: Remove targeted orchestration for patches

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/#review119860
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 19, 2016, 12:09 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43733/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:09 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15097
>     https://issues.apache.org/jira/browse/AMBARI-15097
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.
> 
> Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
>   ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
>   ambari-server/src/main/resources/version_definition.xsd 42035de 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java c6d0c57 
>   ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
>   ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43733/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 3840, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:05.125s
> [INFO] Finished at: Thu Feb 18 16:27:14 EST 2016
> [INFO] Final Memory: 32M/658M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 43733: Remove targeted orchestration for patches

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/#review119767
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Feb. 18, 2016, 5:09 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43733/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-15097
>     https://issues.apache.org/jira/browse/AMBARI-15097
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.
> 
> Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
>   ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
>   ambari-server/src/main/resources/version_definition.xsd 42035de 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java c6d0c57 
>   ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
>   ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43733/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 3840, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:05.125s
> [INFO] Finished at: Thu Feb 18 16:27:14 EST 2016
> [INFO] Final Memory: 32M/658M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 43733: Remove targeted orchestration for patches

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 5:09 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-15097
    https://issues.apache.org/jira/browse/AMBARI-15097


Repository: ambari


Description
-------

Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.

Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
  ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
  ambari-server/src/main/resources/version_definition.xsd 42035de 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java c6d0c57 
  ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
  ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/43733/diff/


Testing
-------

Manual.  Automated:

Tests run: 3840, Failures: 0, Errors: 0, Skipped: 34

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:05.125s
[INFO] Finished at: Thu Feb 18 16:27:14 EST 2016
[INFO] Final Memory: 32M/658M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 43733: Remove targeted orchestration for patches

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43733/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 5:09 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-15097
    https://issues.apache.org/jira/browse/AMBARI-15097


Repository: ambari


Description
-------

Remove targeted orchestration for patches.  This is to make sure that when a patch-type repository is added that the full orchestration occurrs.

Also added a fix whereby if a Version Definition file defines no available services, that it supplies versions for all the manifest services instead.  This way the UI doesn't have to decide to do work on an empty array.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java f29ed40 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java ce5606e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 40565c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 49b2b45 
  ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java a610bd0 
  ambari-server/src/main/resources/version_definition.xsd 42035de 
  ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java 4ba5967 
  ambari-server/src/test/resources/version_definition_test_all_services.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/43733/diff/


Testing (updated)
-------

Manual.  Automated:

Tests run: 3840, Failures: 0, Errors: 0, Skipped: 34

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33:05.125s
[INFO] Finished at: Thu Feb 18 16:27:14 EST 2016
[INFO] Final Memory: 32M/658M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole