You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/01 20:00:30 UTC

[GitHub] [druid] ccaominh commented on a change in pull request #9957: support customized factory.json via IndexSpec for segment persist

ccaominh commented on a change in pull request #9957:
URL: https://github.com/apache/druid/pull/9957#discussion_r433457733



##########
File path: processing/src/main/java/org/apache/druid/segment/IndexSpec.java
##########
@@ -150,13 +174,14 @@ public boolean equals(Object o)
     return Objects.equals(bitmapSerdeFactory, indexSpec.bitmapSerdeFactory) &&
            dimensionCompression == indexSpec.dimensionCompression &&
            metricCompression == indexSpec.metricCompression &&
-           longEncoding == indexSpec.longEncoding;
+           longEncoding == indexSpec.longEncoding &&

Review comment:
       May be useful to add an `EqualsVerifier` test to `IndexSpecTest` for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org