You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by wi...@apache.org on 2020/09/29 15:11:17 UTC

[incubator-superset] branch master updated: Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045)

This is an automated email from the ASF dual-hosted git repository.

willbarrett pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 89bf765  Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045)
89bf765 is described below

commit 89bf76553e79ddf8746eaa3c8ce4b28b0a2ef2de
Author: Kasia Kucharczyk <25...@users.noreply.github.com>
AuthorDate: Tue Sep 29 17:10:46 2020 +0200

    Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045)
---
 superset/tasks/schedules.py | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/superset/tasks/schedules.py b/superset/tasks/schedules.py
index 2cc1280..39394c0 100644
--- a/superset/tasks/schedules.py
+++ b/superset/tasks/schedules.py
@@ -34,7 +34,7 @@ from typing import (
     TYPE_CHECKING,
     Union,
 )
-from urllib.error import URLError  # pylint: disable=ungrouped-imports
+from urllib.error import URLError
 
 import croniter
 import simplejson as json
@@ -72,7 +72,6 @@ from superset.utils.urls import get_url_path
 # pylint: disable=too-few-public-methods
 
 if TYPE_CHECKING:
-    # pylint: disable=unused-import
     from flask_appbuilder.security.sqla.models import User
     from werkzeug.datastructures import TypeConversionDict
 
@@ -485,8 +484,8 @@ def deliver_slice(  # pylint: disable=too-many-arguments
     bind=True,
     soft_time_limit=config["EMAIL_ASYNC_TIME_LIMIT_SEC"],
 )
-def schedule_email_report(  # pylint: disable=unused-argument
-    task: Task,
+def schedule_email_report(
+    _task: Task,
     report_type: ScheduleType,
     schedule_id: int,
     recipients: Optional[str] = None,
@@ -541,8 +540,8 @@ def schedule_email_report(  # pylint: disable=unused-argument
     retry_kwargs={"max_retries": 5},
     retry_backoff=True,
 )
-def schedule_alert_query(  # pylint: disable=unused-argument
-    task: Task,
+def schedule_alert_query(
+    _task: Task,
     report_type: ScheduleType,
     schedule_id: int,
     recipients: Optional[str] = None,