You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/07 02:26:55 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #822: ORC-915: Remove `io.netty:netty` from Spark benchmark

dongjoon-hyun opened a new pull request #822:
URL: https://github.com/apache/orc/pull/822


   ### What changes were proposed in this pull request?
   
   This PR aims to remove `io.netty:netty` dependency from Spark benchmark.
   
   ### Why are the changes needed?
   
   ```
   $ ls spark-2.4.8-bin-hadoop2.7/jars/netty-*
   spark-2.4.8-bin-hadoop2.7/jars/netty-3.9.9.Final.jar      spark-2.4.8-bin-hadoop2.7/jars/netty-all-4.1.47.Final.jar
   
   $ ls spark-3.1.2-bin-hadoop3.2/jars/netty-all-4.1.51.Final.jar
   spark-3.1.2-bin-hadoop3.2/jars/netty-all-4.1.51.Final.jar
   ```
   
   ### How was this patch tested?
   
   Manual.
   ```
   $ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c none -f orc
   $ java -jar spark/target/orc-benchmarks-spark-1.8.0-SNAPSHOT.jar spark data
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #822: ORC-915: Remove `io.netty:netty` from Spark benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #822:
URL: https://github.com/apache/orc/pull/822#issuecomment-894592658


   cc @williamhyun and @pgaref 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun merged pull request #822: ORC-915: Remove `io.netty:netty` from Spark benchmark

Posted by GitBox <gi...@apache.org>.
williamhyun merged pull request #822:
URL: https://github.com/apache/orc/pull/822


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #822: ORC-915: Remove `io.netty:netty` from Spark benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #822:
URL: https://github.com/apache/orc/pull/822#issuecomment-894673155


   Thank you for your review and merging, @williamhyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org