You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:12:46 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #10762: optimize select statement that in same datasource route logic
strongduanmu opened a new pull request #10762:
URL: https://github.com/apache/shardingsphere/pull/10762
Ref #10760.
Changes proposed in this pull request:
- optimize select statement that in same datasource route logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10762: optimize select statement that in same datasource route logic
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10762:
URL: https://github.com/apache/shardingsphere/pull/10762#issuecomment-859425559
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10762](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f9542) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f6fda78a6ec6caa30e5fb318602535030cf5c8e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6fda78) will **increase** coverage by `0.01%`.
> The diff coverage is `72.72%`.
> :exclamation: Current head 51f9542 differs from pull request most recent head 4fe0640. Consider uploading reports for the commit 4fe0640 to get more accurate results
[](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10762 +/- ##
============================================
+ Coverage 65.44% 65.45% +0.01%
Complexity 689 689
============================================
Files 1780 1780
Lines 30823 30833 +10
Branches 5551 5555 +4
============================================
+ Hits 20173 20183 +10
Misses 9045 9045
Partials 1605 1605
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10762/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvU2hhcmRpbmdSb3V0ZUVuZ2luZUZhY3RvcnkuamF2YQ==) | `63.63% <0.00%> (-1.99%)` | :arrow_down: |
| [.../engine/type/single/SingleTablesRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10762/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvc2luZ2xlL1NpbmdsZVRhYmxlc1JvdXRpbmdFbmdpbmUuamF2YQ==) | `86.95% <50.00%> (+9.68%)` | :arrow_up: |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/10762/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9TaGFyZGluZ1J1bGUuamF2YQ==) | `75.91% <100.00%> (+1.29%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f6fda78...4fe0640](https://codecov.io/gh/apache/shardingsphere/pull/10762?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10762: optimize select statement that in same datasource route logic
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10762:
URL: https://github.com/apache/shardingsphere/pull/10762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org