You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/31 19:57:42 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8384: Makefile: fix redundant delimiters when using make V=1

xiaoxiang781216 commented on code in PR #8384:
URL: https://github.com/apache/nuttx/pull/8384#discussion_r1092414447


##########
mm/Makefile:
##########
@@ -52,18 +52,18 @@ all: $(BIN)
 .PHONY: context depend clean distclean
 
 $(AOBJS): $(BINDIR)$(DELIM)$(DELIM)%$(OBJEXT): %.S
-	$(call ASSEMBLE, $<, $@)
+	$(call ASSEMBLE, $(realpath $<), $@)

Review Comment:
   but why not move the realpath to ASSEMBLE/COMPILE macro/function instead. There are many place call ASSEBLE/COMPILE/COMPILEXX



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org