You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/13 01:46:53 UTC

[GitHub] [iceberg] renshangtao opened a new pull request, #6577: Fix the problem of shadow jar without modifying meta-inf/services at the same time

renshangtao opened a new pull request, #6577:
URL: https://github.com/apache/iceberg/pull/6577

   #6561 
   
   When I developed ORC encryption, I found that it can be encrypted successfully on IDEA, but failed to execute it in Flink engine.
   
   After troubleshooting, I found that the package path of orc is '/org/apache/iceberg/shaded/org/apache/orc/impl/mask/MaskProvider' but the in the META-INF/services is 'org.apache.orc.impl.mask.MaskProvider'
   
   So when the code is executed to Datamask.Factory.DataMask the ServiceLoader load the Provider.class failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] renshangtao commented on pull request #6577: Fix the problem of shadow jar without modifying meta-inf/services at the same time

Posted by GitBox <gi...@apache.org>.
renshangtao commented on PR #6577:
URL: https://github.com/apache/iceberg/pull/6577#issuecomment-1382632267

   @nastra thank you for your reply. After this modification, the code can be executed as expected. I open the runtime jar package, and the class corresponding to shadowjar in META-INF/services has changed to org.apache.iceberg.shaded.org.apache.orc.inpl.maskMaskProvider, which should be correct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra commented on pull request #6577: Fix the problem of shadow jar without modifying meta-inf/services at the same time

Posted by GitBox <gi...@apache.org>.
nastra commented on PR #6577:
URL: https://github.com/apache/iceberg/pull/6577#issuecomment-1382694306

   > @nastra thank you for your reply. After this modification, the code can be executed as expected. I open the runtime jar package, and the class corresponding to shadowjar in META-INF/services has changed to org.apache.iceberg.shaded.org.apache.orc.inpl.maskMaskProvider, which should be correct
   
   oh you're right, it shows up as the relocated name, all good then and still +1 on merging this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] renshangtao commented on pull request #6577: Fix the problem of shadow jar without modifying meta-inf/services at the same time

Posted by GitBox <gi...@apache.org>.
renshangtao commented on PR #6577:
URL: https://github.com/apache/iceberg/pull/6577#issuecomment-1381284492

   cc @rdblue @openinx 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra commented on pull request #6577: Fix the problem of shadow jar without modifying meta-inf/services at the same time

Posted by GitBox <gi...@apache.org>.
nastra commented on PR #6577:
URL: https://github.com/apache/iceberg/pull/6577#issuecomment-1381445086

   @renshangtao thanks for the PR. That will only add/merge the service descriptor files to the final jar, but I don't think it will actually solve #6561 as that service provider will still have `org.apache.orc.impl.mask.MaskProvider` in it. In any case, I think it's still correct to merge the service descriptor files but we need a way to deal with packages that are being relocated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org