[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3868: Supporting metadata fetch without open file read mode

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3868:
URL: https://github.com/apache/arrow-rs/pull/3868#discussion_r1136884837


##########
object_store/Cargo.toml:
##########
@@ -62,6 +62,9 @@ tokio = { version = "1.25.0", features = ["sync", "macros", "rt", "time", "io-ut
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 tokio = { version = "1.25.0", features = ["sync", "macros", "rt", "time", "io-util"] }
 
+[target.'cfg(not(target_os = "windows"))'.dev-dependencies]

Review Comment:
   ```suggestion
   [target.'cfg(target_family="unix")'.dev-dependencies]
   ```



##########
object_store/src/local.rs:
##########
@@ -1442,3 +1449,29 @@ mod not_wasm_tests {
         assert_eq!(&*read_data, expected_data);
     }
 }
+
+#[cfg(not(target_os = "windows"))]

Review Comment:
   ```suggestion
   #[cfg(target_family="unix")]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org