You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Andras Salamon (JIRA)" <ji...@apache.org> on 2019/04/08 11:22:00 UTC

[jira] [Updated] (OOZIE-3467) Migrate from com.google.common.base.Stopwatch

     [ https://issues.apache.org/jira/browse/OOZIE-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andras Salamon updated OOZIE-3467:
----------------------------------
    Affects Version/s: trunk

> Migrate from com.google.common.base.Stopwatch
> ---------------------------------------------
>
>                 Key: OOZIE-3467
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3467
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Andras Salamon
>            Assignee: Andras Salamon
>            Priority: Major
>
> OOZIE-1826 created {{JvmPauseMonitorService}} which uses Guava's stopwatch. The implementation was heavily inspired by HADOOP-9618. Guava changed the StopWatch class in a way that we either create a version which is compatible in the old (Guava 11) or the new (Guava 27) interface. To make the code Guava version independent we should not use this class anymore. Hadoop also replaced this class in HADOOP-11032.
> We don't really need nanosecond accuracy here, we only read milliseconds from the stopwatch and the default thresholds are 1 second (oozie.service.JvmPauseMonitorService.info-threshold.ms = 1000ms) and 10 seconds (oozie.service.JvmPauseMonitorService.warn-threshold.ms = 10 000ms) so even millisecond is a bit overkill. We could just use {{System.currentTimeMillis()}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)