You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascheman (via GitHub)" <gi...@apache.org> on 2025/05/26 07:58:04 UTC
[PR] Add missing modules to Maven "plexus" overview [maven-site]
ascheman opened a new pull request, #794:
URL: https://github.com/apache/maven-site/pull/794
These modules were missing in the graphics.
Additionally the modules were ordered (slightly)
lexicographically to make alignment
with apache-sources/default.xml easier.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Run `mvn site` and examine output in `target/site` directory.
Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-3489726734
Maybe I should clarify my motivation: I found these modules as part of the _Maven Aggregator_ (maven-sources repository, repo-tool configuration, i.e., default.xml). In my opinion, the [respective documentation](https://maven.apache.org/scm.html) should refer to them in that case.
If they are not part of Maven (but rather 3rd party as @Bukama pointed out), why are they treated as equal citizen in the Maven sources project (i.e., as part of _Full Maven Sources_ in the docs)? In my opinion all related documentation should also contain them (completely). If they should be treated as 3rd party, then why make them part of the Maven sources and its documentation at all? The only thing I suggest is some consistency in treatment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-3418595900
do as you wish:
- either consider this level of detail useful at Maven level
- or simplify, keeping just "components" without details with a link to https://codehaus-plexus.github.io/ because this is where details are to be maintained
I won't fight any choice: it's a matter of taste, given the schema is now generated, every option is maintainable
I have a personal preference for the simplified view because we already have much in the schema at https://maven.apache.org/scm.html
think about what will help other the most in the future:
- complete but complex
- incomplete but simpler, to feel the structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama merged PR #794:
URL: https://github.com/apache/maven-site/pull/794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-2910706589
it has been intentional in the past to keep it simple, when it was a handwritten image
nowadays that it is generated, it's a choice to be done: is it really valuable? is it really "Maven sources"?
I need some time to review the visual result to decide...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-2910210977
Not sure if they are needed. I remember we removed a lot of old stuff to not be included in the diagram anymore (see https://github.com/apache/maven-site/pull/615 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-3418445878
> is it really "Maven sources"?
I argue that they are not. Maven committers don't have permissions for the plexus repositories. For me, the plexus artifacts are regular third party dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-2911349317
To be honest, I didn't check whether it is really part of Maven (but can easily do so). If these components are not part (as dependencies) of any other Maven project, they perhaps could be dropped from sources (aggregator and repo manifest) as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing modules to Maven "plexus" overview [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #794:
URL: https://github.com/apache/maven-site/pull/794#issuecomment-3503622028
> Maybe I should clarify my motivation: I found these modules as part of the _Maven Aggregator_ (maven-sources repository, repo-tool configuration, i.e., default.xml). In my opinion, the [respective documentation](https://maven.apache.org/scm.html) should refer to them in that case.
I agree on this and to add them to the site. I'm personally not 100% happy that the yellow color of Plexus is/was never explained somewhere, but this is no problem of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org