You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2018/05/17 12:21:05 UTC
Review Request 67180: SENTRY-2235: Add hive tests to verify column
privileges for views
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67180/
-----------------------------------------------------------
Review request for sentry, Na Li and Sergio Pena.
Bugs: SENTRY-2235
https://issues.apache.org/jira/browse/SENTRY-2235
Repository: sentry
Description
-------
There are no e2e tests that verify column permissions granted on views. New test is added to verify the same.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java 35f41c6efc15afe566c760ac0e524946e4725991
Diff: https://reviews.apache.org/r/67180/diff/1/
Testing
-------
Added new tests and also made sure that all regresstion passed.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column
privileges for views
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67180/#review203365
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java
Lines 226 (patched)
<https://reviews.apache.org/r/67180/#comment285537>
Why have a if(revoke) if th eonly thing being passed in is true?
- Steve Moist
On May 17, 2018, 12:21 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67180/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 12:21 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2235
> https://issues.apache.org/jira/browse/SENTRY-2235
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There are no e2e tests that verify column permissions granted on views. New test is added to verify the same.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java 35f41c6efc15afe566c760ac0e524946e4725991
>
>
> Diff: https://reviews.apache.org/r/67180/diff/1/
>
>
> Testing
> -------
>
> Added new tests and also made sure that all regresstion passed.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column
privileges for views
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67180/#review205287
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java
Lines 226 (patched)
<https://reviews.apache.org/r/67180/#comment288226>
This private API can be re-used for other tests where the revoke could ne false.
- kalyan kumar kalvagadda
On May 17, 2018, 12:21 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67180/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 12:21 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2235
> https://issues.apache.org/jira/browse/SENTRY-2235
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There are no e2e tests that verify column permissions granted on views. New test is added to verify the same.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java 35f41c6efc15afe566c760ac0e524946e4725991
>
>
> Diff: https://reviews.apache.org/r/67180/diff/1/
>
>
> Testing
> -------
>
> Added new tests and also made sure that all regresstion passed.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 67180: SENTRY-2235: Add hive tests to verify column
privileges for views
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67180/#review203348
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On May 17, 2018, 12:21 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67180/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 12:21 p.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Bugs: SENTRY-2235
> https://issues.apache.org/jira/browse/SENTRY-2235
>
>
> Repository: sentry
>
>
> Description
> -------
>
> There are no e2e tests that verify column permissions granted on views. New test is added to verify the same.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java 35f41c6efc15afe566c760ac0e524946e4725991
>
>
> Diff: https://reviews.apache.org/r/67180/diff/1/
>
>
> Testing
> -------
>
> Added new tests and also made sure that all regresstion passed.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>