You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/15 08:58:51 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #569: Rename verifyCodeStyle to checkCodeStyle
mdedetrich opened a new pull request, #569:
URL: https://github.com/apache/incubator-pekko/pull/569
See https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294331081 for context
@He-Pin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #569: Rename verifyCodeStyle to checkCodeStyle
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #569:
URL: https://github.com/apache/incubator-pekko/pull/569#issuecomment-1678768584
@mdedetrich Now we have two lgtm, let me merge this then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #569: Rename verifyCodeStyle to checkCodeStyle
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #569:
URL: https://github.com/apache/incubator-pekko/pull/569#issuecomment-1678624382
@mdedetrich Will this confuse someone who contributes to both project(pekko & akka), like @dongxuwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #569: Rename verifyCodeStyle to checkCodeStyle
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #569:
URL: https://github.com/apache/incubator-pekko/pull/569#issuecomment-1678634919
> @mdedetrich Will this confuse someone who contributes to both projects(pekko & akka), like @dongxuwang
For me having the commands be consistent amongst pekko projects is more important then being in sync with akka. I can make a command alias from `verifyCodeStyle` to `checkCodeStyle` but I think this is a fairly minor problem.
@pjfanning wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #569: Rename verifyCodeStyle to checkCodeStyle
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #569:
URL: https://github.com/apache/incubator-pekko/pull/569#issuecomment-1678646994
> lgtm, but better with anoter one lgtm?
Sure this is not urgent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #569: Rename verifyCodeStyle to checkCodeStyle
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #569:
URL: https://github.com/apache/incubator-pekko/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org