You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Guillaume Nodet <gn...@apache.org> on 2014/10/21 11:28:12 UTC

[VOTE] Release Apache Mina SSHD 0.13.0

I'd like to call a vote on releasing Apache SSHD 0.13.0

Staging repo at
   https://repository.apache.org/content/repositories/orgapachemina-1008


Release Notes - MINA SSHD - Version 0.13.0

** Bug
    * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
    * [SSHD-311] - NullPointerException on closing ClientSession
    * [SSHD-335] - Wrong EOF error handling in sshd agent
    * [SSHD-336] - Allow ECDSA based public key authentication
    * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
of SSH_FXP_SYMLINK
    * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
ServerSession
    * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
forever
    * [SSHD-353] - The close method on the stream returned by
DefaultSftpClient#read() should be idemptotent
    * [SSHD-355] - Correctly handle permissions when opening files through
SFTP
    * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
always fails
    * [SSHD-364] - Fix SFTP writes with offset

** Improvement
    * [SSHD-334] - Allow disabling the automatic key pair overwrite in
AbstractGeneratorHostKeyProvider
    * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
Compression(s) in pure Java
    * [SSHD-343] - Return substatus int programatically in SshException
    * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
methods to Attributes
    * [SSHD-349] - Add support for Putty channel requests
    * [SSHD-350] - Ensure compatibility with mina 2.0.8
    * [SSHD-354] - SftpClient#write(String path) should support the
OpenMode flags as an argument
    * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
    * [SSHD-360] - Rework CloseableUtils code
    * [SSHD-361] - Upgrade to mina 2.0.8
    * [SSHD-362] - Upgrade to BouncyCastle 1.51
    * [SSHD-363] - Upgrade to jgit 3.4.1
    * [SSHD-365] - Add AES-192-CTR cipher support

** New Feature
    * [SSHD-341] - Support UserInteractive implementations on a per-session
basis
    * [SSHD-358] - Create Builders for SShServer and SShClient so they can
be extended properly


Please review and vote

Cheers,
Guillaume Nodet

RE: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Lyor Goldstein <lg...@vmware.com>.
+1

-----Original Message-----
From: Guillaume Nodet [mailto:gnodet@apache.org] 
Sent: Tuesday, October 21, 2014 12:28
To: dev@mina.apache.org
Subject: [VOTE] Release Apache Mina SSHD 0.13.0

I'd like to call a vote on releasing Apache SSHD 0.13.0

Staging repo at
   https://urldefense.proofpoint.com/v1/url?u=https://repository.apache.org/content/repositories/orgapachemina-1008&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=8os749fCw6D5uj%2BFBSGIP6zKE0hlqGsZDpGpqUAHhmA%3D%0A&m=boW4Agt87FIHigXzbKDEuaCUW3v7IR9up81AC46td2k%3D%0A&s=2249f7f3592100e6f9dd6377eb54c9b164fd44dcaccd77d3a2e0735e40fd60a5


Release Notes - MINA SSHD - Version 0.13.0

** Bug
    * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
    * [SSHD-311] - NullPointerException on closing ClientSession
    * [SSHD-335] - Wrong EOF error handling in sshd agent
    * [SSHD-336] - Allow ECDSA based public key authentication
    * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead of SSH_FXP_SYMLINK
    * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to ServerSession
    * [SSHD-348] - Some SSH threads get blocked in Object.wait() method forever
    * [SSHD-353] - The close method on the stream returned by
DefaultSftpClient#read() should be idemptotent
    * [SSHD-355] - Correctly handle permissions when opening files through SFTP
    * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect - always fails
    * [SSHD-364] - Fix SFTP writes with offset

** Improvement
    * [SSHD-334] - Allow disabling the automatic key pair overwrite in AbstractGeneratorHostKeyProvider
    * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
Compression(s) in pure Java
    * [SSHD-343] - Return substatus int programatically in SshException
    * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther methods to Attributes
    * [SSHD-349] - Add support for Putty channel requests
    * [SSHD-350] - Ensure compatibility with mina 2.0.8
    * [SSHD-354] - SftpClient#write(String path) should support the OpenMode flags as an argument
    * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
    * [SSHD-360] - Rework CloseableUtils code
    * [SSHD-361] - Upgrade to mina 2.0.8
    * [SSHD-362] - Upgrade to BouncyCastle 1.51
    * [SSHD-363] - Upgrade to jgit 3.4.1
    * [SSHD-365] - Add AES-192-CTR cipher support

** New Feature
    * [SSHD-341] - Support UserInteractive implementations on a per-session basis
    * [SSHD-358] - Create Builders for SShServer and SShClient so they can be extended properly


Please review and vote

Cheers,
Guillaume Nodet

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by "Jamie G." <ja...@gmail.com>.
+1 (non-binding)

Cheers,
Jamie

On Wed, Oct 29, 2014 at 8:19 AM, Guillaume Nodet <gn...@apache.org> wrote:
> Can we have a few other pairs of eyes to review this release please ? We're
> still missing binding votes.
>
> 2014-10-21 11:28 GMT+02:00 Guillaume Nodet <gn...@apache.org>:
>
>> I'd like to call a vote on releasing Apache SSHD 0.13.0
>>
>> Staging repo at
>>    https://repository.apache.org/content/repositories/orgapachemina-1008
>>
>>
>> Release Notes - MINA SSHD - Version 0.13.0
>>
>> ** Bug
>>     * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
>>     * [SSHD-311] - NullPointerException on closing ClientSession
>>     * [SSHD-335] - Wrong EOF error handling in sshd agent
>>     * [SSHD-336] - Allow ECDSA based public key authentication
>>     * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
>> of SSH_FXP_SYMLINK
>>     * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
>> ServerSession
>>     * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
>> forever
>>     * [SSHD-353] - The close method on the stream returned by
>> DefaultSftpClient#read() should be idemptotent
>>     * [SSHD-355] - Correctly handle permissions when opening files through
>> SFTP
>>     * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
>> always fails
>>     * [SSHD-364] - Fix SFTP writes with offset
>>
>> ** Improvement
>>     * [SSHD-334] - Allow disabling the automatic key pair overwrite in
>> AbstractGeneratorHostKeyProvider
>>     * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
>> Compression(s) in pure Java
>>     * [SSHD-343] - Return substatus int programatically in SshException
>>     * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
>> methods to Attributes
>>     * [SSHD-349] - Add support for Putty channel requests
>>     * [SSHD-350] - Ensure compatibility with mina 2.0.8
>>     * [SSHD-354] - SftpClient#write(String path) should support the
>> OpenMode flags as an argument
>>     * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
>>     * [SSHD-360] - Rework CloseableUtils code
>>     * [SSHD-361] - Upgrade to mina 2.0.8
>>     * [SSHD-362] - Upgrade to BouncyCastle 1.51
>>     * [SSHD-363] - Upgrade to jgit 3.4.1
>>     * [SSHD-365] - Add AES-192-CTR cipher support
>>
>> ** New Feature
>>     * [SSHD-341] - Support UserInteractive implementations on a
>> per-session basis
>>     * [SSHD-358] - Create Builders for SShServer and SShClient so they can
>> be extended properly
>>
>>
>> Please review and vote
>>
>> Cheers,
>> Guillaume Nodet
>>
>>

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Jeff Genender <jg...@apache.org>.
+1

Jeff

> On Oct 29, 2014, at 4:49 AM, Guillaume Nodet <gn...@apache.org> wrote:
> 
> Can we have a few other pairs of eyes to review this release please ? We're
> still missing binding votes.
> 
> 2014-10-21 11:28 GMT+02:00 Guillaume Nodet <gn...@apache.org>:
> 
>> I'd like to call a vote on releasing Apache SSHD 0.13.0
>> 
>> Staging repo at
>>   https://repository.apache.org/content/repositories/orgapachemina-1008
>> 
>> 
>> Release Notes - MINA SSHD - Version 0.13.0
>> 
>> ** Bug
>>    * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
>>    * [SSHD-311] - NullPointerException on closing ClientSession
>>    * [SSHD-335] - Wrong EOF error handling in sshd agent
>>    * [SSHD-336] - Allow ECDSA based public key authentication
>>    * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
>> of SSH_FXP_SYMLINK
>>    * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
>> ServerSession
>>    * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
>> forever
>>    * [SSHD-353] - The close method on the stream returned by
>> DefaultSftpClient#read() should be idemptotent
>>    * [SSHD-355] - Correctly handle permissions when opening files through
>> SFTP
>>    * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
>> always fails
>>    * [SSHD-364] - Fix SFTP writes with offset
>> 
>> ** Improvement
>>    * [SSHD-334] - Allow disabling the automatic key pair overwrite in
>> AbstractGeneratorHostKeyProvider
>>    * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
>> Compression(s) in pure Java
>>    * [SSHD-343] - Return substatus int programatically in SshException
>>    * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
>> methods to Attributes
>>    * [SSHD-349] - Add support for Putty channel requests
>>    * [SSHD-350] - Ensure compatibility with mina 2.0.8
>>    * [SSHD-354] - SftpClient#write(String path) should support the
>> OpenMode flags as an argument
>>    * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
>>    * [SSHD-360] - Rework CloseableUtils code
>>    * [SSHD-361] - Upgrade to mina 2.0.8
>>    * [SSHD-362] - Upgrade to BouncyCastle 1.51
>>    * [SSHD-363] - Upgrade to jgit 3.4.1
>>    * [SSHD-365] - Add AES-192-CTR cipher support
>> 
>> ** New Feature
>>    * [SSHD-341] - Support UserInteractive implementations on a
>> per-session basis
>>    * [SSHD-358] - Create Builders for SShServer and SShClient so they can
>> be extended properly
>> 
>> 
>> Please review and vote
>> 
>> Cheers,
>> Guillaume Nodet
>> 
>> 


Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Guillaume Nodet <gn...@apache.org>.
Can we have a few other pairs of eyes to review this release please ? We're
still missing binding votes.

2014-10-21 11:28 GMT+02:00 Guillaume Nodet <gn...@apache.org>:

> I'd like to call a vote on releasing Apache SSHD 0.13.0
>
> Staging repo at
>    https://repository.apache.org/content/repositories/orgapachemina-1008
>
>
> Release Notes - MINA SSHD - Version 0.13.0
>
> ** Bug
>     * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
>     * [SSHD-311] - NullPointerException on closing ClientSession
>     * [SSHD-335] - Wrong EOF error handling in sshd agent
>     * [SSHD-336] - Allow ECDSA based public key authentication
>     * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
> of SSH_FXP_SYMLINK
>     * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
> ServerSession
>     * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
> forever
>     * [SSHD-353] - The close method on the stream returned by
> DefaultSftpClient#read() should be idemptotent
>     * [SSHD-355] - Correctly handle permissions when opening files through
> SFTP
>     * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
> always fails
>     * [SSHD-364] - Fix SFTP writes with offset
>
> ** Improvement
>     * [SSHD-334] - Allow disabling the automatic key pair overwrite in
> AbstractGeneratorHostKeyProvider
>     * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
> Compression(s) in pure Java
>     * [SSHD-343] - Return substatus int programatically in SshException
>     * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
> methods to Attributes
>     * [SSHD-349] - Add support for Putty channel requests
>     * [SSHD-350] - Ensure compatibility with mina 2.0.8
>     * [SSHD-354] - SftpClient#write(String path) should support the
> OpenMode flags as an argument
>     * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
>     * [SSHD-360] - Rework CloseableUtils code
>     * [SSHD-361] - Upgrade to mina 2.0.8
>     * [SSHD-362] - Upgrade to BouncyCastle 1.51
>     * [SSHD-363] - Upgrade to jgit 3.4.1
>     * [SSHD-365] - Add AES-192-CTR cipher support
>
> ** New Feature
>     * [SSHD-341] - Support UserInteractive implementations on a
> per-session basis
>     * [SSHD-358] - Create Builders for SShServer and SShClient so they can
> be extended properly
>
>
> Please review and vote
>
> Cheers,
> Guillaume Nodet
>
>

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Emmanuel Lécharny <el...@gmail.com>.
Guillaume, you are spot on.

I re-read http://www.apache.org/dev/licensing-howto.html again, and
checked the binary and source packages, they are all good.

My +1 !

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Guillaume Nodet <gn...@apache.org>.
The binary distribution includes the needed licenses, but they are
concatenated in a single file LICENSE.txt.
For the binary distribution, only slf4j and bouncy castle are included, the
other dependencies are mostly test dependencies or optional (and not
included in the binary distribution).  That seems a common practice too.

For the source distribution, my understanding is that the LICENSE/NOTICE
files need only to cover the files included in the distribution (same as
the binary distributions), not everything that is needed during the build,
else we'd need all files for various maven plugins and transitive
dependencies.   So my feeling is that it is correct, but I could be wrong.

Guillaume

2014-10-22 8:03 GMT+02:00 Emmanuel Lécharny <el...@gmail.com>:

> Le 21/10/14 11:28, Guillaume Nodet a écrit :
> > I'd like to call a vote on releasing Apache SSHD 0.13.0
> > Please review and vote
>
> Hi Guillaume,
>
> I just built from the source with no problem.
>
> However, I checked the NOTICE and LICENSE files, and it seems you have
> no reference to many dependencies used in the project :
>
> - jzlib
> - BC
> - SLF4J
> - jsch
> - junit
> - jpam
> - ganymed-ssh2
> - jgit
>
> I think we need to have a LICENSE.<xyz>.txt file per dependency, and a
> reference to these licence files in NOTICE.
>
> wdyt ?
>
>

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 21/10/14 11:28, Guillaume Nodet a écrit :
> I'd like to call a vote on releasing Apache SSHD 0.13.0
> Please review and vote

Hi Guillaume,

I just built from the source with no problem.

However, I checked the NOTICE and LICENSE files, and it seems you have
no reference to many dependencies used in the project :

- jzlib
- BC
- SLF4J
- jsch
- junit
- jpam
- ganymed-ssh2
- jgit

I think we need to have a LICENSE.<xyz>.txt file per dependency, and a
reference to these licence files in NOTICE.

wdyt ?


Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Ashish <pa...@gmail.com>.
+1 (binding)

Ran the build, works good, all test cases passed.

On Tue, Oct 21, 2014 at 2:58 PM, Guillaume Nodet <gn...@apache.org> wrote:
> I'd like to call a vote on releasing Apache SSHD 0.13.0
>
> Staging repo at
>    https://repository.apache.org/content/repositories/orgapachemina-1008
>
>
> Release Notes - MINA SSHD - Version 0.13.0
>
> ** Bug
>     * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
>     * [SSHD-311] - NullPointerException on closing ClientSession
>     * [SSHD-335] - Wrong EOF error handling in sshd agent
>     * [SSHD-336] - Allow ECDSA based public key authentication
>     * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
> of SSH_FXP_SYMLINK
>     * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
> ServerSession
>     * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
> forever
>     * [SSHD-353] - The close method on the stream returned by
> DefaultSftpClient#read() should be idemptotent
>     * [SSHD-355] - Correctly handle permissions when opening files through
> SFTP
>     * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
> always fails
>     * [SSHD-364] - Fix SFTP writes with offset
>
> ** Improvement
>     * [SSHD-334] - Allow disabling the automatic key pair overwrite in
> AbstractGeneratorHostKeyProvider
>     * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
> Compression(s) in pure Java
>     * [SSHD-343] - Return substatus int programatically in SshException
>     * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
> methods to Attributes
>     * [SSHD-349] - Add support for Putty channel requests
>     * [SSHD-350] - Ensure compatibility with mina 2.0.8
>     * [SSHD-354] - SftpClient#write(String path) should support the
> OpenMode flags as an argument
>     * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
>     * [SSHD-360] - Rework CloseableUtils code
>     * [SSHD-361] - Upgrade to mina 2.0.8
>     * [SSHD-362] - Upgrade to BouncyCastle 1.51
>     * [SSHD-363] - Upgrade to jgit 3.4.1
>     * [SSHD-365] - Add AES-192-CTR cipher support
>
> ** New Feature
>     * [SSHD-341] - Support UserInteractive implementations on a per-session
> basis
>     * [SSHD-358] - Create Builders for SShServer and SShClient so they can
> be extended properly
>
>
> Please review and vote
>
> Cheers,
> Guillaume Nodet



-- 
thanks
ashish

Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal

Re: [VOTE] Release Apache Mina SSHD 0.13.0

Posted by Guillaume Nodet <gn...@apache.org>.
+1

2014-10-21 11:28 GMT+02:00 Guillaume Nodet <gn...@apache.org>:

> I'd like to call a vote on releasing Apache SSHD 0.13.0
>
> Staging repo at
>    https://repository.apache.org/content/repositories/orgapachemina-1008
>
>
> Release Notes - MINA SSHD - Version 0.13.0
>
> ** Bug
>     * [SSHD-69] - SshAgent test leaks /tmp/mina*apr sockets
>     * [SSHD-311] - NullPointerException on closing ClientSession
>     * [SSHD-335] - Wrong EOF error handling in sshd agent
>     * [SSHD-336] - Allow ECDSA based public key authentication
>     * [SSHD-342] - DefaultSftpClient.symlink calls SSH_FXP_RENAME instead
> of SSH_FXP_SYMLINK
>     * [SSHD-347] - Sftplet.onConnect(...) does not obtain access to
> ServerSession
>     * [SSHD-348] - Some SSH threads get blocked in Object.wait() method
> forever
>     * [SSHD-353] - The close method on the stream returned by
> DefaultSftpClient#read() should be idemptotent
>     * [SSHD-355] - Correctly handle permissions when opening files through
> SFTP
>     * [SSHD-357] - ARCFOUR 128/256 ciphers initialization incorrect -
> always fails
>     * [SSHD-364] - Fix SFTP writes with offset
>
> ** Improvement
>     * [SSHD-334] - Allow disabling the automatic key pair overwrite in
> AbstractGeneratorHostKeyProvider
>     * [SSHD-339] - Remove JCraft Jzlib dependency by implementing the
> Compression(s) in pure Java
>     * [SSHD-343] - Return substatus int programatically in SshException
>     * [SSHD-345] - Add isDirectory, isSymlink, isRegularFIle, and isOther
> methods to Attributes
>     * [SSHD-349] - Add support for Putty channel requests
>     * [SSHD-350] - Ensure compatibility with mina 2.0.8
>     * [SSHD-354] - SftpClient#write(String path) should support the
> OpenMode flags as an argument
>     * [SSHD-359] - Make DefaultSshFuture a bit more lightweight
>     * [SSHD-360] - Rework CloseableUtils code
>     * [SSHD-361] - Upgrade to mina 2.0.8
>     * [SSHD-362] - Upgrade to BouncyCastle 1.51
>     * [SSHD-363] - Upgrade to jgit 3.4.1
>     * [SSHD-365] - Add AES-192-CTR cipher support
>
> ** New Feature
>     * [SSHD-341] - Support UserInteractive implementations on a
> per-session basis
>     * [SSHD-358] - Create Builders for SShServer and SShClient so they can
> be extended properly
>
>
> Please review and vote
>
> Cheers,
> Guillaume Nodet
>
>