You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/06/14 00:38:00 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2338: fix: solve config bool field zero value bug by using pointer
codecov-commenter commented on PR #2338:
URL: https://github.com/apache/dubbo-go/pull/2338#issuecomment-1590254761
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2338](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3f61fcc) into [release-3.0](https://app.codecov.io/gh/apache/dubbo-go/commit/316fa9b865183ed129a633ff6c7c8f13eeaa68de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (316fa9b) will **decrease** coverage by `0.06%`.
> The diff coverage is `69.23%`.
> :exclamation: Current head 3f61fcc differs from pull request most recent head 258f46f. Consider uploading reports for the commit 258f46f to get more accurate results
```diff
@@ Coverage Diff @@
## release-3.0 #2338 +/- ##
===============================================
- Coverage 43.98% 43.93% -0.06%
===============================================
Files 284 284
Lines 17336 17337 +1
===============================================
- Hits 7626 7617 -9
- Misses 8905 8916 +11
+ Partials 805 804 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [cluster/router/tag/match.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL21hdGNoLmdv) | `90.69% <0.00%> (ø)` | |
| [config/provider\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `41.53% <ø> (ø)` | |
| [config/tracing\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3RyYWNpbmdfY29uZmlnLmdv) | `66.66% <ø> (ø)` | |
| [protocol/dubbo3/dubbo3\_invoker.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19pbnZva2VyLmdv) | `58.33% <0.00%> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `56.02% <0.00%> (ø)` | |
| [cluster/router/tag/router.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlci5nbw==) | `60.34% <75.00%> (+0.69%)` | :arrow_up: |
| [config/logger\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `60.93% <100.00%> (ø)` | |
| [config/router\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `77.19% <100.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go/pull/2338/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org