You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2024/03/08 18:50:38 UTC

(pinot) branch master updated: Upgrade RoaringBitmap to 1.0.5 to pick up the fix for RangeBitmap.between() (#12604)

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b123cb965 Upgrade RoaringBitmap to 1.0.5 to pick up the fix for RangeBitmap.between() (#12604)
6b123cb965 is described below

commit 6b123cb965cf17e5144b2d85cd36d5c9eb7cb089
Author: Xiaotian (Jackie) Jiang <17...@users.noreply.github.com>
AuthorDate: Fri Mar 8 10:50:32 2024 -0800

    Upgrade RoaringBitmap to 1.0.5 to pick up the fix for RangeBitmap.between() (#12604)
---
 .../segment/local/segment/index/readers/BitSlicedRangeIndexReader.java | 3 +--
 pom.xml                                                                | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
index a761603d3a..a21891e238 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
@@ -188,8 +188,7 @@ public class BitSlicedRangeIndexReader implements RangeIndexReader<ImmutableRoar
         if (min == max) {
           return rangeBitmap.eq(min).toMutableRoaringBitmap();
         }
-        // TODO: found bug in between() and use gte(lte) as a workaround for now.
-        return rangeBitmap.gte(min, rangeBitmap.lte(max)).toMutableRoaringBitmap();
+        return rangeBitmap.between(min, max).toMutableRoaringBitmap();
       }
       return rangeBitmap.lte(max).toMutableRoaringBitmap();
     } else {
diff --git a/pom.xml b/pom.xml
index 2a894c35d5..98a2fd0041 100644
--- a/pom.xml
+++ b/pom.xml
@@ -415,7 +415,7 @@
       <dependency>
         <groupId>org.roaringbitmap</groupId>
         <artifactId>RoaringBitmap</artifactId>
-        <version>0.9.38</version>
+        <version>1.0.5</version>
       </dependency>
       <dependency>
         <groupId>com.101tec</groupId>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org