[GitHub] [daffodil-vscode] michael-hoke commented on pull request #305: Add semantic highlighting for XPath expressions

["michael-hoke (via GitHub)" <gi...@apache.org>]

michael-hoke commented on PR #305:
URL: https://github.com/apache/daffodil-vscode/pull/305#issuecomment-1581425218

   @stevedlawrence @mbeckerle
   
   We've got some questions on the licensing that we hope you can help clear up. The DeltaXML extension, which is where most of the code comes from, uses MIT licensing, which requires us to use the MIT license in all copied files. However, we have a couple of scenarios:
   
   - We've copied the file from DeltaXML, but we have removed portions of the code as the extension will never use it. Is the MIT license appropriate here?
   
   - We've made a small modification to the copied DeltaXML file. I think out of the two modifications, one was reverting where I took too much code out, and the other was adding in new code. Do we need to combine the MIT and Apache licenses somehow?
   
   - We have a file that has both significant portions of copied sections of a DeltaXML file and sections written by us. Is a combined license appropriate here?
   
   If we do need a combined license, what would that look like?
   
   @NolanMatt Is this an accurate characterization of the changes you've made, and/or am I missing anything?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org