You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/02/10 17:46:55 UTC
Review Request 30834: Remove deprecated API for /stacks2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30834/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-9552
https://issues.apache.org/jira/browse/AMBARI-9552
Repository: ambari
Description
-------
API for /stacks2 is deprecated and should be removed from the server side as
it causes side-effects for regular /stacks API.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 429f779
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 980a40f
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java 855ee8c
ambari-server/src/main/java/org/apache/ambari/server/api/resources/OperatingSystemResourceDefinition.java 6faf6fb
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryResourceDefinition.java be78136
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java abc69f6
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 5da9847
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackConfigurationResourceDefinition.java 53903ba
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java 0743a7f
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java 9265234
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java cad2a99
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinition.java ef76694
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 3310f57
ambari-server/src/main/java/org/apache/ambari/server/api/services/Stacks2Service.java 41ba5ae
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 74c7b57
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 63ec0ed
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java b72f872
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 863ed96
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java 86bffdd
ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinitionTest.java 115e012
ambari-server/src/test/java/org/apache/ambari/server/api/services/Stacks2ServiceTest.java 51609cc
ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java c36c6d9
Diff: https://reviews.apache.org/r/30834/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 30834: Remove deprecated API for /stacks2
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30834/#review71800
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Лют. 10, 2015, 4:46 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30834/
> -----------------------------------------------------------
>
> (Updated Лют. 10, 2015, 4:46 після полудня)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-9552
> https://issues.apache.org/jira/browse/AMBARI-9552
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API for /stacks2 is deprecated and should be removed from the server side as
> it causes side-effects for regular /stacks API.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinition.java 429f779
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java 980a40f
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentStackVersionResourceDefinition.java 855ee8c
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/OperatingSystemResourceDefinition.java 6faf6fb
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryResourceDefinition.java be78136
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinition.java abc69f6
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 5da9847
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackConfigurationResourceDefinition.java 53903ba
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackDependencyResourceDefinition.java 0743a7f
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackLevelConfigurationResourceDefinition.java 9265234
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceComponentResourceDefinition.java cad2a99
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinition.java ef76694
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 3310f57
> ambari-server/src/main/java/org/apache/ambari/server/api/services/Stacks2Service.java 41ba5ae
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 74c7b57
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 63ec0ed
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java b72f872
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 863ed96
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseStacksResourceDefinitionTest.java 86bffdd
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinitionTest.java 115e012
> ambari-server/src/test/java/org/apache/ambari/server/api/services/Stacks2ServiceTest.java 51609cc
> ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java c36c6d9
>
> Diff: https://reviews.apache.org/r/30834/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>