You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/17 11:39:31 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26922:
[MINOR][SQL][DOC] Fix some ambiguous descriptions and format issue in
Dataset API Doc
HyukjinKwon commented on a change in pull request #26922: [MINOR][SQL][DOC] Fix some ambiguous descriptions and format issue in Dataset API Doc
URL: https://github.com/apache/spark/pull/26922#discussion_r358743857
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1868,9 +1868,9 @@ class Dataset[T] private[sql](
/**
* Define (named) metrics to observe on the Dataset. This method returns an 'observed' Dataset
* that returns the same result as the input, with the following guarantees:
- * - It will compute the defined aggregates (metrics) on all the data that is flowing through the
+ * - It will compute the defined aggregates (metrics) on all the data that is flowing through the
* Dataset at that point.
- * - It will report the value of the defined aggregate columns as soon as we reach a completion
+ * - It will report the value of the defined aggregate columns as soon as we reach a completion
Review comment:
To make completely fix it, you gotta use HTML tag to render properly in both javadoc and scaladoc. See https://github.com/apache/spark/blob/9dedfeffaa27a00f719b5a50ce1692f6a0ad665d/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L527-L536 as an example.
You can simply revert this change too here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org