[GitHub] apex-core pull request #360: APEXCORE-495 supporting apps in config package.

[davidyan74 <gi...@git.apache.org>]

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r72669919
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/cli/ApexCli.java ---
    @@ -3850,6 +3908,9 @@ private Option add(Option opt)
         final Option exactMatch = add(new Option("exactMatch", "Only consider applications with exact app name"));
         final Option queue = add(OptionBuilder.withArgName("queue name").hasArg().withDescription("Specify the queue to launch the application").create("queue"));
         final Option force = add(new Option("force", "Force launch the application. Do not check for compatibility"));
    +    final Option onlyConfigApps = add(new Option("onlyConfigApps", "Only use the apps present in the config package."));
    +    final Option skipConfigApps = add(new Option("skipConfigApps", "Skip the apps present in the config package."));
    +
    --- End diff --
    
    Instead of having two options that conflict each other, why don't we have one option that takes a value? for example --useConfigPackageApps={exclusive|inclusive|none}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---