You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/11/07 20:02:00 UTC

[jira] [Work logged] (HIVE-26712) HCatMapReduceTest writes test files in project base directory instead of build directory.

     [ https://issues.apache.org/jira/browse/HIVE-26712?focusedWorklogId=824014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824014 ]

ASF GitHub Bot logged work on HIVE-26712:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/22 20:01
            Start Date: 07/Nov/22 20:01
    Worklog Time Spent: 10m 
      Work Description: cnauroth opened a new pull request, #3738:
URL: https://github.com/apache/hive/pull/3738

   ### What changes were proposed in this pull request?
   
   Move `HCatMapReduceTest` test files from `hcatalog/core` to a path under `hcatalog/core/target`.
   
   ### Why are the changes needed?
   
   Subclasses of `HCatMapReduceTest` produce files under `hcatalog/core`. This causes a few minor irritations:
   
   1. There is a separate `.gitignore` maintained just for the sake of these files.
   1. They are not removed by an `mvn clean`.
   1. During release verification, while doing multiple `mvn` runs, the extra files cause the RAT check to fail.
   
   This can be fixed by moving the files under `hcatalog/core/target`.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   I ran the following in my local environment:
   
   ```
   mvn clean test -Dtest=TestHCatDynamicPartitioned,TestHCatPartitioned,TestHCatNonPartitioned
   ```
   
   After applying the patch, I observed the files now get generated under `hcatalog/core/target`. The `.gitignore` is no longer required. Repeated `mvn` runs don't trigger a failure in the RAT checks on those files.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 824014)
    Remaining Estimate: 0h
            Time Spent: 10m

> HCatMapReduceTest writes test files in project base directory instead of build directory.
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-26712
>                 URL: https://issues.apache.org/jira/browse/HIVE-26712
>             Project: Hive
>          Issue Type: Bug
>          Components: Test
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Subclasses of {{HCatMapReduceTest}} produce files under {{hcatalog/core}}. This causes a few minor irritations:
> # There is a separate {{.gitignore}} maintained just for the sake of these files.
> # They are not removed by an {{mvn clean}}.
> # During release verification, while doing multiple {{mvn}} runs, the extra files cause the RAT check to fail.
> This can be fixed by moving the files under {{hcatalog/core/target}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)